Fix bug in match checking #9747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, thanks! Just a small comment to get the tests passing, and then I believe this is ready to go. |
When `specialize`ing struct-like enum patterns, compare struct fields to pattern fields, not pattern fields to pattern fields. Closes #8351.
|
fixed |
bors
added a commit
that referenced
this pull request
Oct 8, 2013
When `specialize`ing struct-like enum patterns, compare struct fields to pattern fields, not pattern fields to pattern fields. Closes #8351.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 21, 2022
[`option_if_let_else`] do not lint if any arm has guard fix rust-lang/rust-clippy#9742 changelog: [`option_if_let_else`] do not lint if any arm has guard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
specializeing struct-like enum patterns, compare struct fields topattern fields, not pattern fields to pattern fields.
Closes #8351.