Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup feature name to be more consistent with others #97596

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Fixup feature name to be more consistent with others #97596

merged 1 commit into from
Jun 1, 2022

Conversation

WaffleLapkin
Copy link
Member

slice_from_mut_ptr_range_const -> const_slice_from_mut_ptr_range, we usually have const in the front.

I've made a typo in #97419

@WaffleLapkin
Fixup feature name to be more consistent with others
2aef6c5 
`slice_from_mut_ptr_range_const` -> `const_slice_from_mut_ptr_range`,
we usually have `const` in the front.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 31, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2022
@compiler-errors
Copy link
Member

r? @compiler-errors
@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 31, 2022

📌 Commit 2aef6c5 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request May 31, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 31, 2022
@bors
Auto merge of rust-lang#97600 - matthiaskrgr:rollup-yivyeu5, r=matthi…
6f481f8 
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#97316 (Put a bound on collection misbehavior)
 - rust-lang#97578 (alloc: remove repeated word in comment)
 - rust-lang#97593 (:arrow_up: rust-analyzer)
 - rust-lang#97596 (Fixup feature name to be more consistent with others)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 31fccd1 into rust-lang:master Jun 1, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 1, 2022
@WaffleLapkin WaffleLapkin deleted the fixup_feature_name branch February 6, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
6 participants
@WaffleLapkin @rust-highfive @compiler-errors @bors @kennytm @rustbot