support for GNU configure syntax #9760
Conversation
|
cc me |
|
Oh sorry @Heather I missed your questions in the other PR. I think my previous comment explained more or less how to convert to the new variable names. To make mandir do something useful you'll need to export |
|
@brson thank you , I never used to work with hand-written configure scripts. |
|
Maybe old commands can be dropped as soon as the buildbots are edited to work with GNU commands? |
|
@adridu59 yes |
|
This pull request is ready / and waiting for review. |
|
fork moved to |
|
Besides my comment about the linux target triple, this looks great! Thanks for sticking with it. It does need a rebase now though. |
|
@brson thank you, but one of #rust irc users was confused about renaming all CFG_***_TRIPLE to remove TRIPLE word, so I really hope it's fine thing to do. Re-base is easy but separating unknown fix is a bit more of work ... I can do it but it will take some more time. Are you sure that it's not safe to replace unknown-lunux-gnu with pc-linux-gnu right now? Because at least mingw already on pc- and I don't get why linux is still being on unknown. |
|
re-based. |
|
Superseded by #9990 |
Add new lint [`let_underscore_future`] This closes rust-lang#9721 --- changelog: add new lint [`let_underscore_future`]
Downgrade let_underscore_untyped to restriction From reading rust-lang#6842 I am not convinced of the cost/benefit of this lint even as a pedantic lint. It sounds like the primary motivation was to catch cases of `fn() -> Result` being changed to `async fn() -> Result`. If the original Result was ignored by a `let _`, then the compiler wouldn't guide you to add `.await`. **However, this situation is caught in a more specific way by [let_underscore_future](https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future) which was introduced _after_ the original suggestion (rust-lang#9760).** In rust-lang#10410 it was mentioned twice that a <kbd>restriction</kbd> lint might be more appropriate for let_underscore_untyped. changelog: Moved [`let_underscore_untyped`] to restriction
Re-created: #9565
t will be useful for unix systems, some package managers and external tools that is passing / maybe looking for GNU configure syntax options.
One of related bugs: #5138
Also that could be useful in future if project will really install man pages / other stuff using those variables.