Do not ICE when failing to normalize during inlining. #97696
Merged
+39
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I wonder if we should just remove the icy versions of these functions. |
I think we ought to -- places that really need them to be infallible should be responsible for it with |
This comment has been minimized.
This comment has been minimized.
cjgillot
force-pushed
the
normalize-inline
branch
from
f4d722f to
5f48478
Compare
cjgillot
force-pushed
the
normalize-inline
branch
from
5f48478 to
2e301c8
Compare
|
Anyways, removing those functions is probably follow-up work. r=me once CI is happy |
|
@bors r+ |
|
📌 Commit 2e301c8 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 4, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#97446 (Make hir().get_generics and generics_of consistent.) - rust-lang#97656 (Add a suggestion to replace parentheses with angle brackets on associated trait constraint) - rust-lang#97692 (Add `#T-types/nominated` zulip notification) - rust-lang#97696 (Do not ICE when failing to normalize during inlining.) - rust-lang#97702 (Remove useless LocalDefId in ImplTraitContext::Universal.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97695