-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Run compat_fn
init before C++ init
#97816
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #99553) made this pull request unmergeable. Please resolve the merge conflicts. |
1007156
to
2b9613c
Compare
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
2b9613c
to
05e1ff6
Compare
Rebased. The other PR addressed many of the problems in the original issue by making sure we depend less on the initializer having already been run. But currently r? @thomcc since we were talking about something related. |
I'm closing in favour of #100127. Though I may reopen if that isn't merged. |
Fixes #97814
This takes the first option on the above issue. Instead of using C++ initializer functions for dynamically loading Windows API functions, this uses C initializer functions. These will be run before C++ initializers, allowing third party code to be able to use pre-main initializers without having to worry that some function or other may not yet be available.
@rustbot label +O-windows