Rollup of 6 pull requests #97939
Merged
Rollup of 6 pull requests #97939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves rust-lang#85821. See also the discussion here: emscripten-core/emscripten#17128 The consensus seems to be that rust_eh_personality is never invoked. I patched __gxx_personality_v0 to log invocations and then ran various panic tests and it was never called, so this analysis matches what seems to happen in practice. This replaces the definition with an abort, modeled on the structured exception handling implementation.
…e-for-expect, r=wesleywiser Fix `delayed_good_path_bug` ice for expected diagnostics (RFC 2383) Fixes a small ICE with the `delayed_good_path_bug` check. --- r? ``@wesleywiser`` cc: ``@eddyb`` this might be interesting, since you've added a `FIXME` comment above the modified check which kind of discusses a case like this closes: rust-lang#95540 cc: rust-lang#85549
…nTitor,yaahc update docs for `std::future::IntoFuture` Ref rust-lang#67644. This updates the docs for `IntoFuture` providing a bit more guidance on how to use it. Thanks!
… r=Amanieu Don't use __gxx_personality_v0 in panic_unwind on emscripten target This resolves rust-lang#85821. See also the discussion here: emscripten-core/emscripten#17128 The consensus seems to be that rust_eh_personality is never invoked. I patched __gxx_personality_v0 to log invocations and then ran various panic tests and it was never called, so this analysis matches what seems to happen in practice. This replaces the definition with an abort, modeled on the structured exception handling implementation.
…serve, r=the8472 Remove redundant calls to reserve in impl Write for VecDeque Removes the reserve calls made redundant by rust-lang#95904 (as discussed in rust-lang#95632 (comment))
Do not introduce bindings for types and consts in HRTB. Fixes rust-lang#97836 r? `@petrochenkov`
…tatic, r=Dylan-DPC Fix a typo in `test/ui/hrtb/hrtb-just-for-static.rs` closes rust-lang#97934
rustbot
added
T-compiler
|
@bors r+ rollup=never p=6 |
|
📌 Commit 9d25bc3 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Jun 10, 2022
|
Finished benchmarking commit (f19ccc2): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
delayed_good_path_bugice for expected diagnostics (RFC 2383) #97718 (Fixdelayed_good_path_bugice for expected diagnostics (RFC 2383))std::future::IntoFuture#97876 (update docs forstd::future::IntoFuture)test/ui/hrtb/hrtb-just-for-static.rs#97937 (Fix a typo intest/ui/hrtb/hrtb-just-for-static.rs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup