Add String::replace_first and String::replace_last
#97977
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rustbot
added
the
T-libs
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
For now I have manually specified the types in the test and doctest, but these should of course be omitted once the issue is resolved. |
|
@rustbot label +T-libs-api -T-libs |
rustbot
added
T-libs-api
This comment has been minimized.
This comment has been minimized.
WilliamVenner
force-pushed
the
string_replace_in_place
branch
from
004561b to
eb1fa3c
Compare
This comment has been minimized.
This comment has been minimized.
|
@WilliamVenner FYI: when a PR is ready for review, send a message containing @rustbot author |
rustbot
added
S-waiting-on-author
|
@WilliamVenner @rustbot label: +S-inactive |
rustbot
added
the
S-inactive
|
??? This is blocked by #98941 @JohnCSimon |
|
@WilliamVenner sorry - my mistake, reopened. |
JohnCSimon
added
S-blocked
This comment has been minimized.
This comment has been minimized.
Dylan-DPC
removed
the
S-waiting-on-author
|
☔ The latest upstream changes (presumably #93455) made this pull request unmergeable. Please resolve the merge conflicts. |
|
https://github.com/zachs18/rust/tree/string_replace_in_place_rebase |
WilliamVenner
force-pushed
the
string_replace_in_place
branch
from
85d91c6 to
8dd1b5e
Compare
|
@zachs18 Thank you 🙂 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@rustbot label: -S-blocked |
rustbot
removed
the
S-blocked
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Dylan-DPC
added
the
S-waiting-on-author
|
☔ The latest upstream changes (presumably #130674) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@WilliamVenner |
|
@WilliamVenner |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 22, 2025
…base, r=joshtriplett Add `String::replace_first` and `String::replace_last` Rebase of rust-lang#97977 (cc `@WilliamVenner)` > Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows. The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs. ACP: rust-lang/libs-team#506
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Oct 23, 2025
…base, r=joshtriplett Add `String::replace_first` and `String::replace_last` Rebase of rust-lang#97977 (cc `@WilliamVenner)` > Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows. The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs. ACP: rust-lang/libs-team#506
rust-timer
added a commit
that referenced
this pull request
Oct 23, 2025
Rollup merge of #134316 - zachs18:string_replace_in_place_rebase, r=joshtriplett Add `String::replace_first` and `String::replace_last` Rebase of #97977 (cc `@WilliamVenner)` > Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows. The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around #98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs. ACP: rust-lang/libs-team#506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convenience methods that use
match_indicesandreplace_rangeto efficiently replace a substring in a string without reallocating, if capacity (and the implementation ofVec::splice) allows.