Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to statically link libstdc++ on Solaris #98081

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

gco
Copy link
Contributor

@gco gco commented Jun 14, 2022

Fixes #97260

Fixes: Error on bootstrapping : Empty search path given via '-L' (solaris) rust-lang#97260
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2022
@gco gco changed the title Do not try to statically link libstd++ on Solaris Do not try to statically link libstdc++ on Solaris Jun 15, 2022
@jyn514
Copy link
Member

jyn514 commented Jun 17, 2022

Solaris generally prefers dynamic linking and does not ship system libraries in static form. There are no first-party packages to install to get a static libstdc++, only shared objects are provided.

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Jun 17, 2022

📌 Commit 6f0d614 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2022
@jyn514
Copy link
Member

jyn514 commented Jun 17, 2022

(I think it's technically possible for someone to provide their own static libc++ on Solaris, but that seems quite rare and they can always patch bootstrap or open an issue if necessary.)

@bors
Copy link
Contributor

bors commented Jun 17, 2022

⌛ Testing commit 6f0d614 with merge c3b7d7b...

@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) O-solaris Operating system: Solaris labels Jun 17, 2022
@bors
Copy link
Contributor

bors commented Jun 17, 2022

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing c3b7d7b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 17, 2022
@bors bors merged commit c3b7d7b into rust-lang:master Jun 17, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 17, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c3b7d7b): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
2.6% 2.6% 1
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
2.8% 3.5% 2
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-solaris Operating system: Solaris S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on bootstrapping : Empty search path given via '-L' (solaris)
7 participants