once cell renamings #98165

WaffleLapkin · 2022-06-16T11:58:53Z

This PR does the renamings proposed in #74465 (comment)

Move/rename lazy::{OnceCell, Lazy} to cell::{OnceCell, LazyCell}
Move/rename lazy::{SyncOnceCell, SyncLazy} to sync::{OnceLock, LazyLock}

(I used Lazy... instead of ...Lazy as it seems to be more consistent, easier to pronounce, etc)

@rustbot label +T-libs-api -T-libs

rust-highfive · 2022-06-16T11:58:56Z

Some changes occurred in clean/types.rs.

cc @camelid

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

rust-highfive · 2022-06-16T11:58:57Z

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

src/tools/clippy/clippy_utils/src/lib.rs

veber-alex · 2022-06-16T16:30:15Z

LazyLock is kind of a strange name considering you still need a Mutex or a RwLock to get a mutable reference.

flip1995

Clippy changes LGTM now 👍

m-ou-se · 2022-06-18T17:07:18Z

Thanks! Looks good to me. Looking at the tracking issue, it seems like there's consensus for this change.

@bors r+

bors · 2022-06-18T17:07:20Z

📌 Commit c1a2db3 has been approved by m-ou-se

… r=m-ou-se once cell renamings This PR does the renamings proposed in rust-lang#74465 (comment) - Move/rename `lazy::{OnceCell, Lazy}` to `cell::{OnceCell, LazyCell}` - Move/rename `lazy::{SyncOnceCell, SyncLazy}` to `sync::{OnceLock, LazyLock}` (I used `Lazy...` instead of `...Lazy` as it seems to be more consistent, easier to pronounce, etc) `@rustbot` label +T-libs-api -T-libs

… r=m-ou-se once cell renamings This PR does the renamings proposed in rust-lang#74465 (comment) - Move/rename `lazy::{OnceCell, Lazy}` to `cell::{OnceCell, LazyCell}` - Move/rename `lazy::{SyncOnceCell, SyncLazy}` to `sync::{OnceLock, LazyLock}` (I used `Lazy...` instead of `...Lazy` as it seems to be more consistent, easier to pronounce, etc) ``@rustbot`` label +T-libs-api -T-libs

…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#97511 (Don't build the compiler before building rust-demangler) - rust-lang#98165 (once cell renamings) - rust-lang#98207 (Update cargo) - rust-lang#98229 (Add new eslint checks) - rust-lang#98230 (Fix weird js condition) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-lang/rust#98165 landed in the latest Rust nightly version, which made Dependabot CI runs to fail. Try to get builds working again by updating the references to the old names accordingly. While at it, let's also do some minor dependency version bumps.

… r=m-ou-se once cell renamings This PR does the renamings proposed in rust-lang#74465 (comment) - Move/rename `lazy::{OnceCell, Lazy}` to `cell::{OnceCell, LazyCell}` - Move/rename `lazy::{SyncOnceCell, SyncLazy}` to `sync::{OnceLock, LazyLock}` (I used `Lazy...` instead of `...Lazy` as it seems to be more consistent, easier to pronounce, etc) ```@rustbot``` label +T-libs-api -T-libs

The updates required were related to the following changes: - Simplify memory ordering intrinsics - rust-lang/rust#97423 - once cell renamings - rust-lang/rust#98165 - Rename the ConstS::val field as kind - rust-lang/rust#97935 - Remove the source archive functionality of ArchiveWriter - rust-lang/rust#98098 - Use valtrees as the type-system representation for constant values - rust-lang/rust#96591

* Update toolchain to 2022-07-05 The updates required were related to the following changes: - Simplify memory ordering intrinsics - rust-lang/rust#97423 - once cell renamings - rust-lang/rust#98165 - Rename the ConstS::val field as kind - rust-lang/rust#97935 - Remove the source archive functionality of ArchiveWriter - rust-lang/rust#98098 - Use valtrees as the type-system representation for constant values - rust-lang/rust#96591 * Codegen unimplemented for unsupported constant slices See #1339 for more details. * Fix copyright check * Use codegen_option_span instead

… r=m-ou-se once cell renamings This PR does the renamings proposed in rust-lang#74465 (comment) - Move/rename `lazy::{OnceCell, Lazy}` to `cell::{OnceCell, LazyCell}` - Move/rename `lazy::{SyncOnceCell, SyncLazy}` to `sync::{OnceLock, LazyLock}` (I used `Lazy...` instead of `...Lazy` as it seems to be more consistent, easier to pronounce, etc) ```@rustbot``` label +T-libs-api -T-libs

`lazy::SyncLazy` was renamed to `sync::LazyLock` in rust-lang/rust#98165

PR rust-lang#98165 with commits 7c360dc and c1a2db3 has moved all of the components of these modules into different places, namely {std,core}::sync and {std,core}::cell. The empty modules remained. As they are unstable, we can simply remove them.

est31 · 2022-10-08T13:59:14Z

This seems to have missed the removal of the std::lazy and core::lazy modules. Was this intentional? If not, I've filed #102812 to remove those modules.

Remove empty core::lazy and std::lazy PR rust-lang#98165 with commits 7c360dc and c1a2db3 has moved all of the components of these modules into different places, namely {std,core}::sync and {std,core}::cell. The empty modules remained. As they are unstable, we can simply remove them.

WaffleLapkin · 2022-10-09T12:51:25Z

@est31 this wasn't intentional, thanks for filling the PR ❤️

`lazy::SyncLazy` was renamed to `sync::LazyLock` in rust-lang/rust#98165

…s possible Since 1.80: rust-lang/rust#109736 and rust-lang/rust#98165 Non-Thread-Safe Lazy → std::cell::LazyCell https://doc.rust-lang.org/nightly/std/cell/struct.LazyCell.html Thread-safe SyncLazy → std::sync::LazyLock https://doc.rust-lang.org/nightly/std/sync/struct.LazyLock.html The compiler accepted LazyCell only in minilints. The final use in rslib/src/log.rs couldn't be replaced since get_or_try_init has not yet been standardized: rust-lang/rust#109737

… possible Since 1.80: rust-lang/rust#109736 and rust-lang/rust#98165 Non-Thread-Safe Lazy → std::cell::LazyCell https://doc.rust-lang.org/nightly/std/cell/struct.LazyCell.html Thread-safe SyncLazy → std::sync::LazyLock https://doc.rust-lang.org/nightly/std/sync/struct.LazyLock.html The compiler accepted LazyCell only in minilints. The final use in rslib/src/log.rs couldn't be replaced since get_or_try_init has not yet been standardized: rust-lang/rust#109737

* Anki: Replace lazy_static with once_cell Unify to once_cell, lazy_static's replacement. The latter in unmaintained. * Anki: Replace once_cell with stabilized LazyCell / LazyLock as far as possible Since 1.80: rust-lang/rust#109736 and rust-lang/rust#98165 Non-Thread-Safe Lazy → std::cell::LazyCell https://doc.rust-lang.org/nightly/std/cell/struct.LazyCell.html Thread-safe SyncLazy → std::sync::LazyLock https://doc.rust-lang.org/nightly/std/sync/struct.LazyLock.html The compiler accepted LazyCell only in minilints. The final use in rslib/src/log.rs couldn't be replaced since get_or_try_init has not yet been standardized: rust-lang/rust#109737 * Declare correct MSRV (dae) Some of our deps require newer Rust versions, so this was misleading. Updating the MSRV also allows us to use .inspect() on Option now

rust-highfive assigned m-ou-se Jun 16, 2022

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 16, 2022

rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 16, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2022

WaffleLapkin force-pushed the once_things_renamings branch from f2a6b3c to de7a5b7 Compare June 16, 2022 13:05

This comment has been minimized.

Sign in to view

flip1995 requested changes Jun 16, 2022

View reviewed changes

src/tools/clippy/clippy_utils/src/lib.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

WaffleLapkin added 2 commits June 16, 2022 19:53

Move/rename lazy::{OnceCell, Lazy} to cell::{OnceCell, LazyCell}

7c360dc

Move/rename lazy::Sync{OnceCell,Lazy} to sync::{Once,Lazy}Lock

c1a2db3

WaffleLapkin force-pushed the once_things_renamings branch from 30f7dd7 to c1a2db3 Compare June 16, 2022 15:56

flip1995 approved these changes Jun 17, 2022

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2022

matthiaskrgr mentioned this pull request Jun 18, 2022

Rollup of 6 pull requests #98234

Closed

matthiaskrgr mentioned this pull request Jun 18, 2022

Rollup of 5 pull requests #98236

Closed

matthiaskrgr mentioned this pull request Jun 18, 2022

Rollup of 5 pull requests #98242

Merged

bors merged commit f351f34 into rust-lang:master Jun 19, 2022

infiniteregrets mentioned this pull request Jun 20, 2022

Fix once cell renamings metalbear-co/mirrord#158

Closed

decentclock mentioned this pull request Jun 20, 2022

Rename SyncLazy to LazyLock stakwork/sphinx-key#33

Merged

infiniteregrets mentioned this pull request Jun 20, 2022

Fix once cell renamings metalbear-co/mirrord#159

Merged

rennergade mentioned this pull request Jun 23, 2022

Lazy updates Lind-Project/safeposix-rust#138

Merged

falsetru mentioned this pull request Jul 1, 2022

OnceCell 경로 변경 반영 boj-rs/basm-rs#23

Merged

HerringtonDarkholme added a commit to HerringtonDarkholme/vue-compiler that referenced this pull request Jul 1, 2022

fix: fix SyncLazy rename to LazyLock rust-lang/rust#98165

94c4a47

celinval mentioned this pull request Jul 6, 2022

Update toolchain to 2022-07-05 model-checking/kani#1340

Merged

4 tasks

dtolnay removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 6, 2022

Undin added a commit to intellij-rust/intellij-rust that referenced this pull request Aug 6, 2022

Use sync::LazyLock instead of lazy::SyncLazy in attributes-info

42d222d

`lazy::SyncLazy` was renamed to `sync::LazyLock` in rust-lang/rust#98165

est31 mentioned this pull request Oct 8, 2022

Remove empty core::lazy and std::lazy #102812

Merged

kalintas mentioned this pull request Feb 1, 2023

change lazy::SyncLazy to sync::LazyLock brkydnc/num#1

Merged

yopox pushed a commit to Kobzol/intellij-rust that referenced this pull request Feb 27, 2023

Use sync::LazyLock instead of lazy::SyncLazy in attributes-info

7b676db

`lazy::SyncLazy` was renamed to `sync::LazyLock` in rust-lang/rust#98165

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

once cell renamings #98165

once cell renamings #98165

WaffleLapkin commented Jun 16, 2022

rust-highfive commented Jun 16, 2022

rust-highfive commented Jun 16, 2022

This comment has been minimized.

This comment has been minimized.

veber-alex commented Jun 16, 2022

flip1995 left a comment

m-ou-se commented Jun 18, 2022

bors commented Jun 18, 2022

est31 commented Oct 8, 2022

WaffleLapkin commented Oct 9, 2022

once cell renamings #98165

once cell renamings #98165

Conversation

WaffleLapkin commented Jun 16, 2022

rust-highfive commented Jun 16, 2022

rust-highfive commented Jun 16, 2022

This comment has been minimized.

This comment has been minimized.

veber-alex commented Jun 16, 2022

flip1995 left a comment

Choose a reason for hiding this comment

m-ou-se commented Jun 18, 2022

bors commented Jun 18, 2022

est31 commented Oct 8, 2022

WaffleLapkin commented Oct 9, 2022