Support setting file accessed/modified timestamps #98246

joshtriplett · 2022-06-19T03:59:00Z

Add struct FileTimes to contain the relevant file timestamps, since
most platforms require setting all of them at once. (This also allows
for future platform-specific extensions such as setting creation time.)

Add File::set_file_time to set the timestamps for a File.

Implement the sys backends for UNIX, macOS (which needs to fall back
to futimes before macOS 10.13 because it lacks futimens), Windows,
and WASI.

rust-highfive · 2022-06-19T03:59:04Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-06-19T03:59:05Z

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

m-ou-se · 2022-06-20T09:15:09Z

@bors r+

bors · 2022-06-20T09:15:11Z

📌 Commit 8f3fc2e5de8d702b93bb5cf1432630ab721f78d8 has been approved by m-ou-se

m-ou-se · 2022-06-20T09:20:16Z

@bors r-

Actually, set_times should probably take FileTimes by value rather than by reference, since it's a Copy type. Then it's also consistent with the signature of set_permissions.

m-ou-se · 2022-06-21T09:58:10Z

@bors r+

bors · 2022-06-21T09:58:12Z

📌 Commit 585767d has been approved by m-ou-se

Support setting file accessed/modified timestamps Add `struct FileTimes` to contain the relevant file timestamps, since most platforms require setting all of them at once. (This also allows for future platform-specific extensions such as setting creation time.) Add `File::set_file_time` to set the timestamps for a `File`. Implement the `sys` backends for UNIX, macOS (which needs to fall back to `futimes` before macOS 10.13 because it lacks `futimens`), Windows, and WASI.

JohnTitor · 2022-06-21T22:01:14Z

Failed in rollup: #98347 (comment)
Seems some tweaks are needed on macOS.
@bors r-

joshtriplett · 2022-07-30T20:46:38Z

@bors r=m-ou-se

bors · 2022-07-30T20:46:39Z

📌 Commit f8061dd has been approved by m-ou-se

It is now in the queue for this repository.

bors · 2022-07-31T02:15:26Z

⌛ Testing commit f8061dd with merge eb5c3654b416912da280a0808ac36499e50d3bfe...

bors · 2022-07-31T06:30:26Z

💥 Test timed out

rust-log-analyzer · 2022-07-31T07:35:33Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

joshtriplett · 2022-07-31T15:40:49Z

@bors retry

bors · 2022-08-01T06:44:46Z

⌛ Testing commit f8061dd with merge 1f5d8d4...

bors · 2022-08-01T09:25:27Z

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 1f5d8d4 to master...

rust-timer · 2022-08-01T10:41:07Z

Finished benchmarking commit (1f5d8d4): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.5%	2.5%	1
Improvements 🎉 (primary)	-2.3%	-2.3%	1
Improvements 🎉 (secondary)	-2.9%	-3.4%	2
All 😿🎉 (primary)	-2.3%	-2.3%	1

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-3.1%	-3.1%	1
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

…-98246, r=joshtriplett kmc-solid: Add a stub implementation of rust-lang#98246 (`File::set_times`) Fixes the build failure of the [`*-kmc-solid_*`](https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html) Tier 3 targets after rust-lang#98246. This target does not support setting a modification time and access time separately, hence stubbing out the implementation.

Rollup of 6 pull requests Successful merges: - rust-lang#99835 (Suggest adding/removing `ref` for binding patterns) - rust-lang#100155 (Use `node_type_opt` to skip over generics that were not expected) - rust-lang#100157 (rustdoc: use `collect()` instead of repeatedly pushing) - rust-lang#100158 (kmc-solid: Add a stub implementation of rust-lang#98246 (`File::set_times`)) - rust-lang#100166 (Remove more Clean trait implementations) - rust-lang#100168 (Improve diagnostics for `const a: = expr;`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Fix HorizonOS regression in FileTimes The changes in rust-lang#98246 caused a regression for multiple Newlib-based systems. This is just a fix including HorizonOS to the list of targets which require a workaround. `@AzureMarker` `@ian-h-chamberlain` r? `@nagisa`

Fix HorizonOS regression in FileTimes The changes in rust-lang#98246 caused a regression for multiple Newlib-based systems. This is just a fix including HorizonOS to the list of targets which require a workaround. ``@AzureMarker`` ``@ian-h-chamberlain`` r? ``@nagisa``

rust-highfive assigned m-ou-se Jun 19, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 19, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2022

joshtriplett added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 19, 2022

joshtriplett force-pushed the times branch 2 times, most recently from af110f4 to 8f3fc2e Compare June 19, 2022 04:44

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2022

m-ou-se mentioned this pull request Jun 20, 2022

Tracking Issue for feature(file_set_times): FileTimes and File::set_times #98245

Closed

4 tasks

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 20, 2022

joshtriplett force-pushed the times branch from 8f3fc2e to eb6141e Compare June 20, 2022 21:25

joshtriplett added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 20, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2022

Dylan-DPC mentioned this pull request Jun 21, 2022

Rollup of 6 pull requests #98347

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2022

This comment has been minimized.

Sign in to view

Fix warnings in stubbed out set_times

f8061dd

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 31, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 1, 2022

bors merged commit 1f5d8d4 into rust-lang:master Aug 1, 2022

rustbot added this to the 1.64.0 milestone Aug 1, 2022

joshtriplett deleted the times branch August 2, 2022 08:15

kawadakk mentioned this pull request Aug 5, 2022

kmc-solid: Add a stub implementation of #98246 (File::set_times) #100158

Merged

Dylan-DPC mentioned this pull request Aug 5, 2022

Rollup of 6 pull requests #100174

Merged

Meziu mentioned this pull request Aug 7, 2022

Fix HorizonOS regression in FileTimes #100249

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support setting file accessed/modified timestamps #98246

Support setting file accessed/modified timestamps #98246

joshtriplett commented Jun 19, 2022

rust-highfive commented Jun 19, 2022

rust-highfive commented Jun 19, 2022

m-ou-se commented Jun 20, 2022

bors commented Jun 20, 2022

m-ou-se commented Jun 20, 2022

m-ou-se commented Jun 21, 2022

bors commented Jun 21, 2022

JohnTitor commented Jun 21, 2022

This comment has been minimized.

joshtriplett commented Jul 30, 2022

bors commented Jul 30, 2022

bors commented Jul 31, 2022

bors commented Jul 31, 2022

rust-log-analyzer commented Jul 31, 2022

joshtriplett commented Jul 31, 2022

bors commented Aug 1, 2022

bors commented Aug 1, 2022

rust-timer commented Aug 1, 2022

Support setting file accessed/modified timestamps #98246

Support setting file accessed/modified timestamps #98246

Conversation

joshtriplett commented Jun 19, 2022

rust-highfive commented Jun 19, 2022

rust-highfive commented Jun 19, 2022

m-ou-se commented Jun 20, 2022

bors commented Jun 20, 2022

m-ou-se commented Jun 20, 2022

m-ou-se commented Jun 21, 2022

bors commented Jun 21, 2022

JohnTitor commented Jun 21, 2022

This comment has been minimized.

joshtriplett commented Jul 30, 2022

bors commented Jul 30, 2022

bors commented Jul 31, 2022

bors commented Jul 31, 2022

rust-log-analyzer commented Jul 31, 2022

joshtriplett commented Jul 31, 2022

bors commented Aug 1, 2022

bors commented Aug 1, 2022

rust-timer commented Aug 1, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes