Move RegionKind to rustc_type_ir

[jackh726]

(Also UniverseIndex)

r? rust-lang/types

[jackh726]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 1e9f8df with merge 4d6ba22fc03b88084f993c67596efbdcf8b0c96d...

[compiler-errors]

Looks great! I'll give it another look-over once perf gets back and CI looks green, but glad to see that this was a much simpler move than migrating TyKind.

[jackh726]

Looks great! I'll give it another look-over once perf gets back and CI looks green, but glad to see that this was a much simpler move than migrating TyKind.

So much simpler! The worst part was writing the impls 🙃

[compiler-errors]

Oh, did you write them by hand? When I made them for TyKind, I just got them from cargo-expand + a lot of string replacement to clean them up. If you did write them by hand, I'll make sure to give them a particularly close looking over for correctness.

[jackh726]

Oh, did you write them by hand? When I made them for TyKind, I just got them from cargo-expand + a lot of string replacement to clean them up. If you did write them by hand, I'll make sure to give them a particularly close looking over for correctness.

Yeah, I did. Probably would have been roughly the same time to do the other way.

[bors]

☀️ Try build successful - checks-actions
Build commit: 4d6ba22fc03b88084f993c67596efbdcf8b0c96d (4d6ba22fc03b88084f993c67596efbdcf8b0c96d)

[rust-timer]

Queued 4d6ba22fc03b88084f993c67596efbdcf8b0c96d with parent 3b98c08, future comparison URL.

[rust-timer]

Finished benchmarking commit (4d6ba22fc03b88084f993c67596efbdcf8b0c96d): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	1.7%	1.7%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	2.1%	2.1%	1
Regressions 😿 (secondary)	2.5%	2.9%	7
Improvements 🎉 (primary)	-2.5%	-2.5%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.2%	-2.5%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[eggyal]

Does it matter that derive would introduce that bound? In chalk, Copy is a supertrait of Interner; and in rustc, isn't I just a shared ref to the type context (which therefore is indeed Copy)?

I guess the same should apply for Clone even though it is not strictly a supertrait of Interner? After all, requiring I: Clone shouldn't be restrictive if we know that I: Copy.

As an aside, I wonder whether there wouldn't be some ergonomic benefit to using a derivative-like macro here to workaround #26925 without requiring all these manual impls?

[compiler-errors]

@bors r+

🎉

[bors]

📌 Commit 1e9f8df has been approved by compiler-errors

[bors]

⌛ Testing commit 1e9f8df with merge bb8c2f4...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing bb8c2f4 to master...

[rust-timer]

Finished benchmarking commit (bb8c2f4): comparison url.

Instruction count

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	0.4%	0.4%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	3.5%	3.5%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.7%	-2.7%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-2.7%	-2.7%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³