Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MaybeUninit memset test #98304

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Add MaybeUninit memset test #98304

merged 1 commit into from
Aug 29, 2022

Conversation

SUPERCILEX
Copy link
Contributor

Closes #96274

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2022
@SUPERCILEX SUPERCILEX mentioned this pull request Jun 20, 2022
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Copy link
Member

r? @nikic

It could make sense to land this with a min-llvm-version 15, I suppose, but not sure how we feel about such future tests.

@SUPERCILEX
Copy link
Contributor Author

I'm fine just letting this sit until August FYI.

@JohnCSimon
Copy link
Member

ping from triage:
@SUPERCILEX
Returning to you to address broken build

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2022
@SUPERCILEX
Add MaybeUninit memset test
8c62cc2 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Copy link
Contributor Author

@JohnCSimon looks like llvm 13 is still used in CI even though #99464 happened, so I added a // min-llvm-version: 15.0. Is that fine? E.g. will the test actually be run at some point by CI on llvm 15?

@SUPERCILEX
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 25, 2022
@nikic
Copy link
Contributor

nikic commented Aug 28, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Aug 28, 2022

📌 Commit 8c62cc2 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 29, 2022
@Dylan-DPC
Rollup merge of rust-lang#98304 - SUPERCILEX:maybeuninit, r=nikic
23a32d0 
Add MaybeUninit memset test

Closes rust-lang#96274
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 29, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 29, 2022
@bors
Auto merge of rust-lang#101152 - Dylan-DPC:rollup-v4iw8ux, r=Dylan-DPC
bc4b39c 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#98304 (Add MaybeUninit memset test)
 - rust-lang#98801 (Add a `File::create_new` constructor)
 - rust-lang#99821 (Remove separate indexing of early-bound regions)
 - rust-lang#100239 (remove an ineffective check in const_prop)
 - rust-lang#100337 (Stabilize `std::io::read_to_string`)
 - rust-lang#100819 (Make use of `[wrapping_]byte_{add,sub}`)
 - rust-lang#100934 (Remove a panicking branch from `fmt::builders::PadAdapter`)
 - rust-lang#101000 (Separate CountIsStar from CountIsParam in rustc_parse_format.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4cac0bf into rust-lang:master Aug 29, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 29, 2022
@SUPERCILEX SUPERCILEX deleted the maybeuninit branch August 30, 2022 01:37
@SUPERCILEX SUPERCILEX mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikic nikic

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

[MaybeUninit::uninit(); N] memsets memory
8 participants
@SUPERCILEX @rust-highfive @rust-log-analyzer @Mark-Simulacrum @JohnCSimon @nikic @bors @rustbot