Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lies in comments. #98313

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Remove lies in comments. #98313

merged 1 commit into from
Jun 21, 2022

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Jun 20, 2022

does not have a const constructor

pub const fn new() -> Self

🤔

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 20, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2022
@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 20, 2022

📌 Commit a171a6b has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 21, 2022
@matthiaskrgr
Rollup merge of rust-lang#98313 - m-ou-se:fix-comments, r=joshtriplett
a6305a8 
Remove lies in comments.

> does not have a const constructor

> pub const fn new() -> Self

🤔
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 21, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request Jun 21, 2022
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 21, 2022
@JohnTitor
Rollup merge of rust-lang#98313 - m-ou-se:fix-comments, r=joshtriplett
2bbbf6c 
Remove lies in comments.

> does not have a const constructor

> pub const fn new() -> Self

🤔
@JohnTitor JohnTitor mentioned this pull request Jun 21, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 21, 2022
@bors
Auto merge of rust-lang#98335 - JohnTitor:rollup-j2zudxv, r=JohnTitor
72fd41a 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#94033 (Improve docs for `is_running` to explain use case)
 - rust-lang#97269 (adjust transmute const stabilization version)
 - rust-lang#97805 (Add proper tracing spans to rustc_trait_selection::traits::error_reporting)
 - rust-lang#98022 (Fix erroneous span for borrowck error)
 - rust-lang#98124 (Improve loading of crates.js and sidebar-items.js)
 - rust-lang#98278 (Some token stream cleanups)
 - rust-lang#98306 (`try_fold_unevaluated` for infallible folders)
 - rust-lang#98313 (Remove lies in comments.)
 - rust-lang#98323 (:arrow_up: rust-analyzer)
 - rust-lang#98329 (Avoid an ICE and instead let the compiler report a useful error)
 - rust-lang#98330 (update ioslice docs to use shared slices)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 18b01d5 into rust-lang:master Jun 21, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 21, 2022
@m-ou-se m-ou-se deleted the fix-comments branch June 23, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
6 participants
@m-ou-se @rust-highfive @joshtriplett @bors @Mark-Simulacrum @rustbot