Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debuginfo: Generalize C++-like encoding for enums. #98393

Merged
merged 15 commits into from
Aug 15, 2022
Merged

debuginfo: Generalize C++-like encoding for enums. #98393

merged 15 commits into from
Aug 15, 2022

Commits on Aug 12, 2022

  1. debuginfo: Change C++-like encoding for enums. 

    The updated encoding should be able to handle niche layouts where
more than one variant has fields.
    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    622da5d View commit details
    Browse the repository at this point in the history

  2. Use enum2<_> instead of enum<_> for Cpp-like debuginfo enum type names. 

    And add more comments about niche tag enum encoding.
    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    063ebfa View commit details
    Browse the repository at this point in the history

  3. Support wrapping 128-bit tag ranges for cpp-like enum debuginfo.

    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    725ceae View commit details
    Browse the repository at this point in the history

  4. Remove out-dated NatVis visualizer.

    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    6875f12 View commit details
    Browse the repository at this point in the history

  5. intrinsic.natvis: Don't access fields from context object in <Intrins… 

    …ic>.

WinDbg supports that but Visual Studio doesn't. Pass the value as a parameter instead.
    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    1bbda88 View commit details
    Browse the repository at this point in the history

  6. [debuginfo] Add more test cases cpp-like enum debuginfo.

    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    3a72ea0 View commit details
    Browse the repository at this point in the history

  7. intrinsic.natvis: Add comments, make names more consistent.

    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    8ef0301 View commit details
    Browse the repository at this point in the history

  8. [compiletest] Add compiler-bundled NatVis files to test input stamp.

    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    dfb2c89 View commit details
    Browse the repository at this point in the history

  9. [debuginfo] Remove the notion of a 'fallback variant' from the CPP-li… 

    …ke enum debuginfo encoding.
    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    8433e2a View commit details
    Browse the repository at this point in the history

  10. [debuginfo] Don't mark fields and types as artificial in CPP-like enu… 

    …m debuginfo encoding.

LLDB historically has had problems with "artificial" entries and there
is no real benefit to emitting that flag.
    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    171d8a3 View commit details
    Browse the repository at this point in the history

  11. [debuginfo] Update cpp-like enum decoding docs to account for wrappin… 

    …g tag ranges.
    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    95d7591 View commit details
    Browse the repository at this point in the history

  12. [debuginfo] Use IndexMap instead of FxHashMap while generating cpp-li… 

    …ke generator debuginfo.
    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    b0e3ed6 View commit details
    Browse the repository at this point in the history

  13. [debuginfo] Update codegen tests for new cpp-like enum debuginfo enco… 

    …ding.
    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    ee634fb View commit details
    Browse the repository at this point in the history

  14. [debuginfo] Update src/test/debuginfo/mutex.rs for new cpp-like enum … 

    …debuginfo encoding.
    @michaelwoerister
    michaelwoerister committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    6d030a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. [debuginfo] Fix msvc-pretty-enums debuginfo test for i686.

    @michaelwoerister
    michaelwoerister committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    03b93d0 View commit details
    Browse the repository at this point in the history