-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add str::Lines::as_str #98453
Add str::Lines::as_str #98453
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
@jplatte any updates on this pr? |
Don't have much time right now, since it's a small thing I might be able to get to it soon though. If somebody else wants to take over that would be fine by me too, just please ping me so the work isn't duplicated. |
Closing in favor of #107464. Thanks WaffleLapkin! |
…ines, r=dtolnay Add `str::Lines::remainder` Based on rust-lang#98453. This PR adds `str::Lines::remainder` similarly to [other remainder function on str split iterators](rust-lang#77998).
…ines, r=dtolnay Add `str::Lines::remainder` Based on rust-lang#98453. This PR adds `str::Lines::remainder` similarly to [other remainder function on str split iterators](rust-lang#77998).
Rollup merge of rust-lang#107464 - WaffleLapkin:all_that_remains_of_lines, r=dtolnay Add `str::Lines::remainder` Based on rust-lang#98453. This PR adds `str::Lines::remainder` similarly to [other remainder function on str split iterators](rust-lang#77998).
Blocked on #95644, for now I'm using the same API as available onSplitTerminator
but this should probably not be merged as-is since that API is changing.Just wanted to open this now as a means to propose having the same "remainder of non-iterated parts as a contiguous
&str
" API onLines
as onSplit*
(tracked in #77998).I'm also curious whether you think it makes sense to implement it like this (reaching into the inner
SplitTerminator
ofMap
) or whether theMap
should maybe be replaced? I found the code a little hard to follow at first given it usesMap
instead of just (?) doing the same thing manually in theIterator
implementation.