Skip to content

Move some tests to more reasonable directories #98511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move some tests to more reasonable directories #98511

wants to merge 1 commit into from

Conversation

c410-f3r
Copy link
Contributor

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 25, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2022
@bors
Copy link
Collaborator

bors commented Jul 1, 2022

☔ The latest upstream changes (presumably #98402) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov
Copy link
Contributor

issue-43784-supertrait.rs - no associated types involved there
issue-77993-1.rs - no async-await is involved there
issue-3563-2.rs - can be removed now
issue-3563-3.rs - "Demonstrates traits, impls, operator overloading, non-copyable struct, unit testing", not block-result
issue-5500-1.rs - never_type, i guess
issue-48962.rs - drop
issue-17718-* - the issue is so vague that it doesn't make sense to group tests according to it, imo, all the tests in non-issues subdirectories are already in good places
issue-17718-const-privacy.rs - privacy
issue-17718-patterns.rs - pattern
issue-17718-static-move.rs - borrowck
issue-17718-static-sync.rs -> statics
issue-17718-static-unsafe-interior.rs -> statics
issue-64620.rs - no generators involved there
issue-36053.rs - no mismatched types observed there, it's a run-pass test
issue-2718-a.rs - structs-enums or recursion
issue-23338-ensure-param-drop-order.rs - drop
issue-23338-params-outlive-temps-of-body.rs - borrowck
issue-24805-dropck-itemless.rs - dropck
issue-7575.rs - can be removed now

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2022
@JohnCSimon
Copy link
Member

@c410-f3r
ping from triage - can you post your status on this PR and address the review comments? Thanks

@c410-f3r
Copy link
Contributor Author

@c410-f3r ping from triage - can you post your status on this PR and address the review comments? Thanks

I will in a few days. Just needed a little Rustc break

@c410-f3r
Copy link
Contributor Author

@petrochenkov The intention here is to unify all scattered tests that are part of the same issue but it seems that some tests shouldn't be included in the same directory.

Closing in favour of #102055.

@c410-f3r c410-f3r closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@c410-f3r @bors @petrochenkov @JohnCSimon @rust-highfive @rustbot