-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for Box::into_inner
#98523
Conversation
Signed-off-by: blackanger <blackanger.z@gmail.com>
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: blackanger <blackanger.z@gmail.com>
@rustbot ready |
@rustbot blocked. #80437 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing in favor of ongoing discussion in #80437. It seems we don't really have a clear picture what this method is for, and the example here isn't compelling to me. If anyone in #80437 lands on a better example, I'd be happy about a PR for it, otherwise we'll hopefully be removing this method.
Thanks anyway for the contribution!
cc #80437
Signed-off-by: blackanger <bl Improve documentation for Box::into_inner #98523 ackanger.z@gmail.com>
Blocked on tracking issue comment