Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make empty bounds lower to WellFormed and make WellFormed coinductive #98542

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

jackh726
Copy link
Member

r? rust-lang/types

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 26, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2022
@jackh726
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 26, 2022
@bors
Copy link
Collaborator

bors commented Jun 26, 2022

⌛ Trying commit 17fc375eb17df1e939ac23d2297f0642e1cfa6dd with merge c078f423e8387b6d48de9e764d99dfefb7a083e4...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Jun 26, 2022

☀️ Try build successful - checks-actions
Build commit: c078f423e8387b6d48de9e764d99dfefb7a083e4 (c078f423e8387b6d48de9e764d99dfefb7a083e4)

@rust-timer
Copy link
Collaborator

Queued c078f423e8387b6d48de9e764d99dfefb7a083e4 with parent 7125846, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c078f423e8387b6d48de9e764d99dfefb7a083e4): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)
2.6% 2.6% 1
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-3.7% -4.0% 2
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) -1.6% -4.0% 3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change

  2. number of relevant changes

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 26, 2022
@jackh726 jackh726 mentioned this pull request Jun 27, 2022
Comment on lines +2495 to +2496
/// `WellFormed` predicates, and it's very likely that the additional matches
/// will have a perf effect. The value here is the well-formed `GenericArg`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe run perf on that first so we can replace the very likely with been shown

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehh, I would prefer to not try to make that change right now (because it's going to take some time to do right - which is limited for me right now - and I think the time will just be wasted).

@oli-obk
Copy link
Contributor

oli-obk commented Jun 28, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 28, 2022

📌 Commit bd298ad has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2022
@bors
Copy link
Collaborator

bors commented Jun 29, 2022

⌛ Testing commit bd298ad with merge 116edb6...

@bors
Copy link
Collaborator

bors commented Jun 29, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 116edb6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2022
@bors bors merged commit 116edb6 into rust-lang:master Jun 29, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 29, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (116edb6): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-0.6% -0.7% 6
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
5.1% 5.1% 1
Regressions 😿
(secondary)
2.5% 3.8% 2
Improvements 🎉
(primary)
-2.0% -2.0% 1
Improvements 🎉
(secondary)
-3.6% -3.6% 1
All 😿🎉 (primary) 1.5% 5.1% 2

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
2.3% 2.3% 1
Improvements 🎉
(primary)
-3.3% -3.3% 1
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) -3.3% -3.3% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants