-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make empty bounds lower to WellFormed
and make WellFormed
coinductive
#98542
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 17fc375eb17df1e939ac23d2297f0642e1cfa6dd with merge c078f423e8387b6d48de9e764d99dfefb7a083e4... |
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-actions |
Queued c078f423e8387b6d48de9e764d99dfefb7a083e4 with parent 7125846, future comparison URL. |
Finished benchmarking commit (c078f423e8387b6d48de9e764d99dfefb7a083e4): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Footnotes |
/// `WellFormed` predicates, and it's very likely that the additional matches | ||
/// will have a perf effect. The value here is the well-formed `GenericArg` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe run perf on that first so we can replace the very likely
with been shown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ehh, I would prefer to not try to make that change right now (because it's going to take some time to do right - which is limited for me right now - and I think the time will just be wasted).
@bors r+ |
📌 Commit bd298ad has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (116edb6): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
r? rust-lang/types