Skip to content

Fix builds on Windows (closes #98546) #98556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2022
Merged

Fix builds on Windows (closes #98546) #98556

merged 1 commit into from
Jun 27, 2022
+1 −1

Conversation

BlaCoiso
Copy link
Contributor

@BlaCoiso BlaCoiso commented Jun 26, 2022 •
edited by JohnTitor
Loading

closes #98546

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jyn514 (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2022
@jyn514
Copy link
Member

jyn514 commented Jun 26, 2022

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 26, 2022

📌 Commit 15abd82 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2022
@jyn514 jyn514 added O-windows Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust labels Jun 26, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 27, 2022
@bors
Auto merge of rust-lang#98566 - matthiaskrgr:rollup-43etyls, r=matthi…
8e52fa8 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#97389 (Improve memory ordering diagnostics)
 - rust-lang#97780 (Check ADT field is well-formed before checking it is sized)
 - rust-lang#98530 (compiletest: add issue number param to `known-bug`)
 - rust-lang#98556 (Fix builds on Windows (closes rust-lang#98546))
 - rust-lang#98561 (Fix spelling in SAFETY comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 31ec973 into rust-lang:master Jun 27, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 27, 2022
@BlaCoiso BlaCoiso deleted the patch-1 branch June 27, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

Bootstrap build failing on Windows (MSVC)
5 participants
@BlaCoiso @rust-highfive @jyn514 @bors @rustbot