Triagebot: Fix mentions word wrapping. #98636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Hm, I sort of prefer the previous wrapping -- can we at least use the toml backslash to avoid this problem? I'm wondering if we can have triagebot collapse |
|
Sure, I switched it to use backslashes instead. I don't think triagebot can safely join the text. For example, the bullet list would get corrupted. It would need to do a markdown to markdown translation which is not easy. |
|
@bors r+ rollup |
|
📌 Commit b292d94 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 29, 2022
…ulacrum Triagebot: Fix mentions word wrapping. I forgot that GitHub's markdown treats newlines as hard breaks. This was causing some ugly-looking word wrapping in the triagebot mention messages. This fixes it so that the lines are not hard-wrapped.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#98434 (Ensure that `static_crt` is set in the bootstrapper whenever using `cc-rs` to get a compiler command line.) - rust-lang#98636 (Triagebot: Fix mentions word wrapping.) - rust-lang#98642 (Fix rust-lang#98260) - rust-lang#98643 (Improve pretty printing of valtrees for references) - rust-lang#98646 (rustdoc: fix bugs in main.js popover help and settings) - rust-lang#98647 (Update cargo) - rust-lang#98652 (`alloc`: clean and ensure `no_global_oom_handling` builds are warning-free) - rust-lang#98660 (Unbreak stage1 tests via ignore-stage1 in `proc-macro/invalid-punct-ident-1.rs`.) - rust-lang#98665 (Use verbose help for deprecation suggestion) - rust-lang#98668 (Avoid some `&str` to `String` conversions with `MultiSpan::push_span_label`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that GitHub's markdown treats newlines as hard breaks. This was causing some ugly-looking word wrapping in the triagebot mention messages. This fixes it so that the lines are not hard-wrapped.