For diagnostic information of Boolean, remind it as use the type: 'bool' #98677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
lyming2007
force-pushed
the
issue-98492-fix
branch
from
2ffb1fa
to
a03c06c
Compare
lcnr
reviewed
Jun 29, 2022
|
one nit, then r=me. Thanks! r? @lcnr |
lyming2007
force-pushed
the
issue-98492-fix
branch
from
a03c06c
to
006291f
Compare
camelid
reviewed
Jun 29, 2022
lyming2007
force-pushed
the
issue-98492-fix
branch
from
006291f
to
8c8823c
Compare
camelid
reviewed
Jun 29, 2022
This comment has been minimized.
This comment has been minimized.
lyming2007
force-pushed
the
issue-98492-fix
branch
from
8c8823c
to
6a3b91a
Compare
This comment has been minimized.
This comment has been minimized.
It helps programmers coming from other languages modified: compiler/rustc_resolve/src/late/diagnostics.rs modified: src/test/ui/lint/recommend-literal.rs modified: src/test/ui/lint/recommend-literal.stderr modified: compiler/rustc_resolve/src/late/diagnostics.rs modified: src/test/ui/lint/recommend-literal.rs modified: src/test/ui/lint/recommend-literal.stderr modified: compiler/rustc_resolve/src/late/diagnostics.rs modified: src/test/ui/lint/recommend-literal.rs modified: src/test/ui/lint/recommend-literal.stderr
lyming2007
force-pushed
the
issue-98492-fix
branch
from
6a3b91a
to
15d3ea5
Compare
|
@bors r+ rollup |
|
📌 Commit 15d3ea5 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 30, 2022
For diagnostic information of Boolean, remind it as use the type: 'bool' Fixes rust-lang#98492. It helps programmers coming from other languages modified: compiler/rustc_resolve/src/late/diagnostics.rs
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 30, 2022
For diagnostic information of Boolean, remind it as use the type: 'bool' Fixes rust-lang#98492. It helps programmers coming from other languages modified: compiler/rustc_resolve/src/late/diagnostics.rs
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 1, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#97629 ([core] add `Exclusive` to sync) - rust-lang#98503 (fix data race in thread::scope) - rust-lang#98670 (llvm-wrapper: adapt for LLVMConstExtractValue removal) - rust-lang#98671 (Fix source sidebar bugs) - rust-lang#98677 (For diagnostic information of Boolean, remind it as use the type: 'bool') - rust-lang#98684 (add test for 72793) - rust-lang#98688 (interpret: add From<&MplaceTy> for PlaceTy) - rust-lang#98695 (use "or pattern") - rust-lang#98709 (Remove unneeded methods declaration for old web browsers) - rust-lang#98717 (get rid of tidy 'unnecessarily ignored' warnings) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98492.
It helps programmers coming from other languages
modified: compiler/rustc_resolve/src/late/diagnostics.rs