-
Notifications
You must be signed in to change notification settings - Fork 13.3k
doc,rustdoc: improvements #9868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would you mind also uploading a preview of the tutorial and the new std/extra documentation? Thanks for this work! |
|
You might want to use a different favicon for the documentation than the root of the site. |
@thestinger Hmm, not sure what else than the Rust logo we'd want to use, plus the doc itself is part of the Rust website, so... |
|
@thestinger Right, I was focused on the website. |
Okay, log updated. 🍒 |
@cmr I didn't understand the point of the rust class, think it's an old dinosaur: this code spot is the only one in the manual that has this class and in the old CSS it made the code square to have light blue background instead of grey (which I didn't understand why...?) so I dropped it from the CSS too: |
It enables syntax highlighting. On Wed, Oct 16, 2013 at 6:58 AM, Adrien Tétar notifications@github.comwrote:
|
@cmr Nope, tildes are sufficient to enable Rust syntax highlighting (enabled by default), a simple proof of that is that your mentioned snippet is the only one that has the .rust class, but all others in the page are fine (even on current doc). |
Thanks, this is a nice improvement! 🍭 |
- switch pandoc to HTML5, add tutorial PDF gen. - cleanup and refactor CSS, expand tutorial/manual CSS +some Bootstrap elements, cleanup unused doc/lib.css you can see it here in action: http://adrientetar.legtux.org/cached/rust-doc/rust.html - minor rustdoc cleanups @alexcrichton
Not sure what's wrong here, it built fine even before my latest changes on my PC and the error message here is pretty much inexistent. |
Rebased against master, couldn't find any error... bonus: fixed #9911. r? |
Cleanup, edit, add some Bootstrap v3.0.0 elements.
@graydon Could you advise with the Makefile issue? |
$(Q)cp -a $< $@ 2> /dev/null | ||
|
||
doc/manual.css: manual.css | ||
doc/css/rust.css: rust.css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this this the problem: rust.css
doesn't exist? (Maybe you have an old file called rust.css
in some directory?)
(Note: I'm not at all experienced with Makefiles.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also iirc it gave the exact same error when I removed those 3 lines previously @alexcrichton suggested deleting them previously so it might not be the root cause of the error.
This is #9868 but doesn't move css files to a separate subfolder, which was causing errors on the Rust buildbot. @alexcrichton
Closed in favor of #9960. |
This is #9868 but doesn't move css files to a separate subfolder, which was causing errors on the Rust buildbot. @alexcrichton
you can see it here in action: http://adrientetar.legtux.org/cached/rust-doc/rust.html
@alexcrichton