-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #98820
Rollup of 6 pull requests #98820
Conversation
Previously, it required you to manually run `x build` first, because it assumed the LLVM binaries were already present.
…39, r=Mark-Simulacrum Add regression test for rust-lang#50439 closes rust-lang#50439
…ulacrum add ice test for rust-lang#97047 Fixes rust-lang#97047
…crum Fix `x dist rust-dev` on a fresh checkout Previously, it required you to manually run `x build` first, because it assumed the LLVM binaries were already present.
Add rust-lang#95469 to the release notes rust-lang#95469 may break programs using async file handles so it should've been noted in compatibility notes (sorry).
…acrum feat: Add a documentation problem issue template Fixes rust-lang#98722 :)
update Miri Fixes rust-lang#98779 r? `@ghost`
@bors r+ p=5 |
📌 Commit 434ce76 has been approved by |
☀️ Test successful - checks-actions |
Tested on commit rust-lang/rust@f2d9393. Direct link to PR: <rust-lang/rust#98820> 🎉 miri on windows: test-fail → test-pass (cc @oli-obk @RalfJung). 🎉 miri on linux: test-fail → test-pass (cc @oli-obk @RalfJung).
Finished benchmarking commit (f2d9393): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
No changes in compiler/lib, but number of query calls on perf run changed (for example https://perf.rust-lang.org/detailed-query.html?commit=f2d93935ffba3ab9d7ccb5300771a2d29b4c8bf3&base_commit=750d6f85459356db4838dc06db8b19406e1ed31a&benchmark=html5ever-0.26.0-debug&scenario=incr-unchanged), what the source of it can be? |
Based on a wider view of benchmarks over the last week, fairly certain these results were noise -- probably some new non-determinism has snuck in. Dropping regression label. |
Successful merges:
generic_const_exprs
andadt_const_params
#97047)x dist rust-dev
on a fresh checkout #98753 (Fixx dist rust-dev
on a fresh checkout)File
methods #95469 to the release notes)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup