adjust dangling-int-ptr error message #98860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
RalfJung
force-pushed
the
dangling-int-ptr
branch
from
59efe78 to
583d61f
Compare
davidtwco
approved these changes
Jul 4, 2022
|
@bors r+ rollup |
|
📌 Commit 583d61f has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 4, 2022
adjust dangling-int-ptr error message based on suggestions by `@saethlin` in rust-lang/miri#2163 Fixes rust-lang/miri#2163 I also did a bit of refactoring on this, so we have a helper method to create a `Pointer` with `None` provenance.
|
failed in rollup |
|
@bors r- |
bors
added
S-waiting-on-author
|
That's a Miri test failure, which should not block CI? |
|
📌 Commit 583d61f has been approved by |
bors
added
S-waiting-on-bors
|
@Dylan-DPC I think you got the wrong PR, the actual failure error is @bors rollup- |
|
uhm right, not sure why it threw those errors in RLA output |
|
☔ The latest upstream changes (presumably #98910) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
RalfJung
force-pushed
the
dangling-int-ptr
branch
from
583d61f to
46956f7
Compare
|
@bors r=davidtwco |
|
📌 Commit 46956f7 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 5, 2022
adjust dangling-int-ptr error message based on suggestions by ``@saethlin`` in rust-lang/miri#2163 Fixes rust-lang/miri#2163 I also did a bit of refactoring on this, so we have a helper method to create a `Pointer` with `None` provenance.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#98860 (adjust dangling-int-ptr error message) - rust-lang#98888 (interpret: fix CheckedBinOp behavior when overflow checking is disabled) - rust-lang#98889 (Add regression test for rust-lang#79467) - rust-lang#98895 (bootstrap.py: Always use `.exe` for Windows) - rust-lang#98920 (adapt issue-37945 codegen test to accept any order of ops) - rust-lang#98921 (Refactor: remove a redundant mutable variable) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on suggestions by @saethlin in rust-lang/miri#2163
Fixes rust-lang/miri#2163
I also did a bit of refactoring on this, so we have a helper method to create a
PointerwithNoneprovenance.