Add Read Impl for &Stdin #99153

Dajamante · 2022-07-11T13:30:38Z

rust-highfive · 2022-07-11T13:30:41Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information.

rustbot · 2022-07-11T13:30:42Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Dajamante · 2022-07-11T13:31:53Z

@rustbot label +T-libs-api -T-libs

oli-obk · 2022-07-11T13:32:31Z

r? rust-lang/libs-api

oli-obk · 2022-07-11T13:33:19Z

r? @m-ou-se

JohnCSimon · 2022-10-08T23:13:32Z

triage:
@m-ou-se this has sat since July - can you post the status of the review?

Dylan-DPC · 2023-08-24T05:45:21Z

r? @thomcc

thomcc · 2023-08-28T05:30:13Z

This needs ACP.

Ekleog · 2024-01-24T21:21:34Z

If it does, then I think https://std-dev-guide.rust-lang.org/development/feature-lifecycle.html?highlight=acp should be updated? The current documentation seems to indicate that ACP are entirely optional, and are only to avoid working on a PR without it eventually landing (the "Note that an ACP is not strictly required" paragraph in particular).

AFAIU that document's suggestions are that this PR should just go through a T-libs FCP, which seems to be the same understanding as this comment in the related issue (though the process could have changed since)

dtolnay · 2024-01-26T03:14:22Z

library/std/src/io/stdio.rs

@@ -437,6 +437,28 @@ impl Read for Stdin {
 }
 }

+#[stable(feature = "rust1", since = "1.0.0")]


Please choose some other unique feature name and set the stabilization version to "CURRENT_RUSTC_VERSION".

dtolnay · 2024-02-26T07:56:01Z

I filled in a feature name to resolve #99153 (review), and an implementation of Read::read_buf which was added in impl Read for Stdin by #108326 after this PR was originally opened.

dtolnay

Thank you!

dtolnay · 2024-02-26T08:02:48Z

@bors r+

Dylan-DPC · 2024-03-09T07:46:23Z

@bors r=dtolnay

bors · 2024-03-09T07:46:25Z

📌 Commit b18280f has been approved by dtolnay

It is now in the queue for this repository.

Add Read Impl for &Stdin r? `@oli-obk` fixes rust-lang#95622

Rollup of 12 pull requests Successful merges: - rust-lang#99153 (Add Read Impl for &Stdin) - rust-lang#112136 (Add std::ffi::c_str module) - rust-lang#120504 (Vec::try_with_capacity) - rust-lang#121280 (Implement MaybeUninit::fill{,_with,_from}) - rust-lang#121813 (Misc improvements to non local defs lint implementation) - rust-lang#121833 (Suggest correct path in include_bytes!) - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once) - rust-lang#122160 (Eagerly translate `HelpUseLatestEdition` in parser diagnostics) - rust-lang#122178 (ci: add a runner for vanilla LLVM 18) - rust-lang#122186 (Remove a workaround for a bug) - rust-lang#122215 (Some tweaks to the parallel query cycle handler) - rust-lang#122223 (Fix typo in `VisitorResult`) r? `@ghost` `@rustbot` modify labels: rollup

Nadrieril · 2024-03-09T20:33:56Z

@bors rollup

Rollup of 8 pull requests Successful merges: - rust-lang#99153 (Add Read Impl for &Stdin) - rust-lang#114655 (Make `impl<Fd: AsFd>` impl take `?Sized`) - rust-lang#120504 (Vec::try_with_capacity) - rust-lang#121280 (Implement MaybeUninit::fill{,_with,_from}) - rust-lang#121403 (impl From<TryReserveError> for io::Error) - rust-lang#121526 (on the fly type casting for `build.rustc` and `build.cargo`) - rust-lang#121584 (bump itertools to 0.12) - rust-lang#121711 (Implement junction_point) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#99153 - Dajamante:issue/95622, r=dtolnay Add Read Impl for &Stdin r? `@oli-obk` fixes rust-lang#95622

Add Read Impl for &Stdin

709ea74

rust-highfive assigned oli-obk Jul 11, 2022

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 11, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2022

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 11, 2022

rust-highfive assigned m-ou-se and unassigned oli-obk Jul 11, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2022

Noratrieb removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 27, 2022

anden3 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2023

rustbot assigned thomcc and unassigned m-ou-se Aug 24, 2023

thomcc added the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label Aug 28, 2023

dtolnay assigned dtolnay and unassigned thomcc Jan 26, 2024

dtolnay requested changes Jan 26, 2024

View reviewed changes

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2024

dtolnay force-pushed the issue/95622 branch from dc96566 to 2164460 Compare February 26, 2024 07:51

dtolnay added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 26, 2024

dtolnay approved these changes Feb 26, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

dtolnay added 2 commits February 26, 2024 00:01

Fix stable feature name and stabilization version of Read for &Stdin

b921a34

Fill in Read::read_buf for &Stdin

b18280f

dtolnay force-pushed the issue/95622 branch from 2164460 to b18280f Compare February 26, 2024 08:01

apiraino removed the to-announce Announce this issue on triage meeting label Feb 29, 2024

This comment was marked as duplicate.

Sign in to view

Dylan-DPC closed this Mar 9, 2024

Dylan-DPC reopened this Mar 9, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024

jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 9, 2024

Rollup merge of rust-lang#99153 - Dajamante:issue/95622, r=dtolnay

286e813

Add Read Impl for &Stdin r? `@oli-obk` fixes rust-lang#95622

jhpratt mentioned this pull request Mar 9, 2024

Rollup of 12 pull requests #122229

Closed

Nadrieril mentioned this pull request Mar 9, 2024

Rollup of 8 pull requests #122256

Merged

bors merged commit 0a8ea93 into rust-lang:master Mar 9, 2024
22 checks passed

rustbot added this to the 1.78.0 milestone Mar 9, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024

Unrolled build for rust-lang#99153

a0a33c7

Rollup merge of rust-lang#99153 - Dajamante:issue/95622, r=dtolnay Add Read Impl for &Stdin r? `@oli-obk` fixes rust-lang#95622

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Read Impl for &Stdin #99153

Add Read Impl for &Stdin #99153

Dajamante commented Jul 11, 2022

rust-highfive commented Jul 11, 2022

rustbot commented Jul 11, 2022

Dajamante commented Jul 11, 2022

oli-obk commented Jul 11, 2022 •

edited

Loading

oli-obk commented Jul 11, 2022

JohnCSimon commented Oct 8, 2022

Dylan-DPC commented Aug 24, 2023

thomcc commented Aug 28, 2023

Ekleog commented Jan 24, 2024 •

edited

Loading

dtolnay Jan 26, 2024

dtolnay commented Feb 26, 2024

dtolnay left a comment

This comment has been minimized.

dtolnay commented Feb 26, 2024

This comment was marked as duplicate.

Dylan-DPC commented Mar 9, 2024

bors commented Mar 9, 2024

Nadrieril commented Mar 9, 2024

Add Read Impl for &Stdin #99153

Add Read Impl for &Stdin #99153

Conversation

Dajamante commented Jul 11, 2022

rust-highfive commented Jul 11, 2022

rustbot commented Jul 11, 2022

Dajamante commented Jul 11, 2022

oli-obk commented Jul 11, 2022 • edited Loading

oli-obk commented Jul 11, 2022

JohnCSimon commented Oct 8, 2022

Dylan-DPC commented Aug 24, 2023

thomcc commented Aug 28, 2023

Ekleog commented Jan 24, 2024 • edited Loading

dtolnay Jan 26, 2024

Choose a reason for hiding this comment

dtolnay commented Feb 26, 2024

dtolnay left a comment

Choose a reason for hiding this comment

This comment has been minimized.

dtolnay commented Feb 26, 2024

This comment was marked as duplicate.

Dylan-DPC commented Mar 9, 2024

bors commented Mar 9, 2024

Nadrieril commented Mar 9, 2024

oli-obk commented Jul 11, 2022 •

edited

Loading

Ekleog commented Jan 24, 2024 •

edited

Loading