add feature gate for managed boxes #9923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc #7803 |
|
Hold off on this for further discussion. |
|
It's on the meeting agenda for next week. |
I'll flip this on after doing a snapshot. This syntax may or may not stay around, and managed boxes are currently not very useful. They have the same overall performance characteristics as `std::rc::Rc`, but are significantly slower, allocate larger boxes and hold onto the memory beyond when it is needed due to lacking move semantics. There are currently two useful aspects of the type: * the dereference sugar, which we should implement for `Rc` * the annihilator freeing cycles at the end of the task
bors
added a commit
that referenced
this pull request
Oct 22, 2013
I'll flip this on after doing a snapshot. This syntax may or may not stay around, and managed boxes are currently not very useful. They have the same overall performance characteristics as `std::rc::Rc`, but are significantly slower, allocate larger boxes and hold onto the memory beyond when it is needed due to lacking move semantics. There are currently two useful aspects of the type: * the dereference sugar, which we should implement for `Rc` * the annihilator freeing cycles at the end of the task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll flip this on after doing a snapshot. This syntax may or may not
stay around, and managed boxes are currently not very useful. They have
the same overall performance characteristics as
std::rc::Rc, but aresignificantly slower, allocate larger boxes and hold onto the memory
beyond when it is needed due to lacking move semantics.
There are currently two useful aspects of the type:
Rc