Fix starts_with() and ends_with(). #9924
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| #[inline] | ||
| fn ends_with(&self, needle: &str) -> bool { | ||
| let (m, n) = (self.len(), needle.len()); | ||
| m >= n && needle == self.slice_from(m - n) | ||
| m >= n && needle.as_bytes() == self.as_bytes().pslice_from(m - n) |
There was a problem hiding this comment.
wtf? i must have hit Ctrl-t after i ran tests. Fixing.
d4a3238 broke these since slice_to() and slice_from() must get character boundaries, and arbitrary needle lengths don't necessarily map to character boundaries of the haystack. This also adds new tests that would have caught this bug.
bors
added a commit
that referenced
this pull request
Oct 18, 2013
d4a3238 broke these since slice_to() and slice_from() must get character boundaries, and arbitrary needle lengths don't necessarily map to character boundaries of the haystack. This also adds new tests that would have caught this bug.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 1, 2022
Add `clippy_utils::msrv::Msrv` to keep track of the current MSRV changelog: Fix the scoping of the `#![clippy::msrv]` attribute Fixes rust-lang#6920 r? `@Jarcho`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d4a3238 broke these since slice_to() and slice_from() must get character
boundaries, and arbitrary needle lengths don't necessarily map to character
boundaries of the haystack.
This also adds new tests that would have caught this bug.