Formalize defining_use_anchor #99383

ouz-a · 2022-07-17T17:39:56Z

This tackles issue #57961

Introduces new enum called DefiningAnchor that replaces Option<LocalDefId> of defining_use_anchor. Now every use of it is explicit and exhaustively matched, catching errors like one in the linked issue. This is not a perfect fix but it's a step in the right direction.

r? @oli-obk

compiler-errors · 2022-07-17T22:26:14Z

Can you please add a UI test for #99363 since you said that was fixed by this PR? 😸

oli-obk

I don't understand the reasoning behind most of the Bubble calls you added, please document all of them or remove them to keep them as an error

compiler/rustc_borrowck/src/region_infer/opaque_types.rs

compiler/rustc_infer/src/infer/mod.rs

compiler/rustc_infer/src/infer/opaque_types.rs

compiler/rustc_trait_selection/src/traits/codegen.rs

compiler/rustc_typeck/src/check/check.rs

compiler/rustc_typeck/src/check/compare_method.rs

ouz-a · 2022-07-18T14:05:56Z

Can you please add a UI test for #99363 since you said that was fixed by this PR? 😸

There was already a test like that but just added new one with edition:2021

compiler/rustc_infer/src/infer/mod.rs

oli-obk · 2022-07-18T17:44:10Z

@bors r+

bors · 2022-07-18T17:44:11Z

📌 Commit 8267ad738660c32f50343ccecbee5bf13519c371 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2022-07-19T12:16:04Z

☔ The latest upstream changes (presumably #99451) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2022-07-20T10:26:39Z

@bors r+

bors · 2022-07-20T10:26:41Z

📌 Commit 64dc377 has been approved by oli-obk

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - rust-lang#98101 (stdlib support for Apple WatchOS) - rust-lang#99345 (Do not allow typeck children items to constrain outer RPITs) - rust-lang#99383 (Formalize defining_use_anchor) - rust-lang#99436 (Add flag to configure `noalias` on `Box<T>`) - rust-lang#99483 (Fix a numerical underflow in tuple wrap suggestion) - rust-lang#99485 (Stop injecting `#[allow(unused_qualifications)]` in generated `derive` implementations) - rust-lang#99486 (Refactor: remove a string comparison between types in `check_str_addition`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Fix regression introduced with rust-lang#99383 Fixes rust-lang#99642

Rollup of 5 pull requests Successful merges: - rust-lang#99714 (Fix regression introduced with rust-lang#99383) - rust-lang#99723 (Allow using stable os::fd::raw items through unstable os::wasi module) - rust-lang#99810 (Fix settings slider on small width screens) - rust-lang#99837 (Avoid `Symbol` to `String` conversions) - rust-lang#99846 (Refactor `UnresolvedImportError`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

RalfJung · 2022-07-31T13:14:39Z

I think this caused a regression in Miri, introducing a new ICE -- see rust-lang/miri#2433. I don't have any idea what goes on here so not sure about any of the details.^^

bjorn3 · 2022-07-31T13:18:15Z

compiler/rustc_infer/src/infer/mod.rs

-        InferCtxtBuilder { tcx: self, defining_use_anchor: None, fresh_typeck_results: None }
+        InferCtxtBuilder {
+            tcx: self,
+            defining_use_anchor: DefiningAnchor::Error,


This used to be the equivalent to DefiningAnchor::Bubble. I don't see any other behavior changes.

@bjorn3 so could that be the cause of the ICE?

@ouz-a any chance you could look into why Miri started ICEing after this PR?

Ah sorry, I totally forgot about this I will look into this asap.

ouz-a · 2022-08-22T21:52:40Z

@RalfJung

Because of a previous report, I already had a branch where I reverted changes made here, I built MIRI with this repo and still got ICE. Maybe another PR in that roll-up caused that error since #99840 we faced a similar situation.


     Running `target/debug/miri --sysroot /Users/ouz/Library/Caches/org.rust-lang.miri/HOST tabula.rs`
thread 'rustc' panicked at 'assertion failed: `(left == right)`
  left: `Some(Obligation(predicate=Binder(TraitPredicate(<&S as std::marker::Sized>, polarity:Positive), []), depth=0))`,
 right: `None`', compiler/rustc_traits/src/normalize_erasing_regions.rs:40:17
stack backtrace:
   0:        0x104436658 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h502b9907255a9020
   1:        0x1044c1c58 - core::fmt::write::h1312fa7bb85e0d03
   2:        0x104467b54 - std::io::Write::write_fmt::hdc03145f6f1e9dcd
   3:        0x1044364ac - std::sys_common::backtrace::print::h3f2486f04aea89c9
   4:        0x10445fc70 - std::panicking::default_hook::{{closure}}::haa37fd6bee37c759
   5:        0x10445fa18 - std::panicking::default_hook::hc228b3d9e7765ab2
   6:        0x10cf9e394 - rustc_driver[6168a678ad3ae7e8]::DEFAULT_HOOK::{closure#0}::{closure#0}
   7:        0x104460158 - std::panicking::rust_panic_with_hook::h780d45e68728c0ed
   8:        0x104454b08 - std::panicking::begin_panic_handler::{{closure}}::hc8833628902d6139
   9:        0x104454a48 - std::sys_common::backtrace::__rust_end_short_backtrace::h12758624bd828a06
  10:        0x10445fcd0 - _rust_begin_unwind
  11:        0x1044e2c68 - core::panicking::panic_fmt::h855bf55d5a000e71
  12:        0x1044cc4bc - core::panicking::assert_failed_inner::h296340acbf3dd196
  13:        0x1111fe884 - core[e78181ecd1ceeb9c]::panicking::assert_failed::<core[e78181ecd1ceeb9c]::option::Option<&rustc_infer[74bbb1a65a4d2108]::traits::Obligation<rustc_middle[bdd54a4263b5ba61]::ty::Predicate>>, core[e78181ecd1ceeb9c]::option::Option<&rustc_infer[74bbb1a65a4d2108]::traits::Obligation<rustc_middle[bdd54a4263b5ba61]::ty::Predicate>>>
  14:        0x10fd67c58 - <rustc_infer[74bbb1a65a4d2108]::infer::InferCtxtBuilder>::enter::<core[e78181ecd1ceeb9c]::result::Result<rustc_middle[bdd54a4263b5ba61]::ty::subst::GenericArg, rustc_middle[bdd54a4263b5ba61]::traits::query::NoSolution>, rustc_traits[82be05223e04c67b]::normalize_erasing_regions::try_normalize_after_erasing_regions<rustc_middle[bdd54a4263b5ba61]::ty::subst::GenericArg>::{closure#0}>
  15:        0x10fce0924 - rustc_traits[82be05223e04c67b]::normalize_erasing_regions::try_normalize_after_erasing_regions::<rustc_middle[bdd54a4263b5ba61]::ty::subst::GenericArg>
  16:        0x10fd962d8 - <rustc_traits[82be05223e04c67b]::normalize_erasing_regions::provide::{closure#0} as core[e78181ecd1ceeb9c]::ops::function::FnOnce<(rustc_middle[bdd54a4263b5ba61]::ty::context::TyCtxt, rustc_middle[bdd54a4263b5ba61]::ty::ParamEnvAnd<rustc_middle[bdd54a4263b5ba61]::ty::subst::GenericArg>)>>::call_once
  17:        0x11008f42c - rustc_query_system[f60b1df5a59e085c]::query::plumbing::get_query::<rustc_query_impl[3a679ff423363666]::queries::try_normalize_generic_arg_after_erasing_regions, rustc_query_impl[3a679ff423363666]::plumbing::QueryCtxt>
  18:        0x1102d9a00 - <rustc_query_impl[3a679ff423363666]::Queries as rustc_middle[bdd54a4263b5ba61]::ty::query::QueryEngine>::try_normalize_generic_arg_after_erasing_regions
  19:        0x110d18af8 - <rustc_middle[bdd54a4263b5ba61]::ty::normalize_erasing_regions::NormalizeAfterErasingRegionsFolder>::normalize_generic_arg_after_erasing_regions
  20:        0x110d18500 - <rustc_middle[bdd54a4263b5ba61]::ty::normalize_erasing_regions::NormalizeAfterErasingRegionsFolder as rustc_middle[bdd54a4263b5ba61]::ty::fold::TypeFolder>::fold_ty
  21:        0x102d2ace4 - <F as rustc_middle::ty::fold::FallibleTypeFolder>::try_fold_ty::h24c13ced97ba123b
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/fold.rs:216:12
  22:        0x102e8b70c - rustc_middle::ty::structural_impls::<impl rustc_middle::ty::fold::TypeFoldable for rustc_middle::ty::Ty>::try_fold_with::he175f578d2a156c8
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/structural_impls.rs:987:9
  23:        0x102ca3e08 - rustc_middle::ty::util::fold_list::{{closure}}::hd7b28e864b662f36
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/util.rs:1219:61
  24:        0x102c9323c - core::iter::traits::iterator::Iterator::find_map::check::{{closure}}::ha5ba178cfdb7bd06
                               at /Users/ouz/Code/GitHub/rust/library/core/src/iter/traits/iterator.rs:2732:32
  25:        0x102dc25d0 - <core::iter::adapters::enumerate::Enumerate<I> as core::iter::traits::iterator::Iterator>::try_fold::enumerate::{{closure}}::h8edb430b2c4ccedf
                               at /Users/ouz/Code/GitHub/rust/library/core/src/iter/adapters/enumerate.rs:85:27
  26:        0x102e968a8 - core::iter::traits::iterator::Iterator::try_fold::h672ebcdc41a6745c
                               at /Users/ouz/Code/GitHub/rust/library/core/src/iter/traits/iterator.rs:2238:21
  27:        0x102dc1d28 - <core::iter::adapters::enumerate::Enumerate<I> as core::iter::traits::iterator::Iterator>::try_fold::hd05ce0fa767ed83e
                               at /Users/ouz/Code/GitHub/rust/library/core/src/iter/adapters/enumerate.rs:91:9
  28:        0x102dc35d4 - core::iter::traits::iterator::Iterator::find_map::hbf25e6d0208cbe41
                               at /Users/ouz/Code/GitHub/rust/library/core/src/iter/traits/iterator.rs:2738:9
  29:        0x102ca335c - rustc_middle::ty::util::fold_list::habc928cafe10c2ac
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/util.rs:1219:11
  30:        0x102e9b3cc - rustc_middle::ty::subst::<impl rustc_middle::ty::fold::TypeFoldable for &rustc_middle::ty::list::List<rustc_middle::ty::Ty>>::try_fold_with::h6f1546f0de215026
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/subst.rs:488:18
  31:        0x102e21ab0 - rustc_middle::ty::sty::_DERIVE_rustc_middle_ty_fold_TypeFoldable_tcx_FOR_FnSig::<impl rustc_middle::ty::fold::TypeFoldable for rustc_middle::ty::sty::FnSig>::try_fold_with::h9c0f72204c364afa
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/sty.rs:1215:22
  32:        0x102e2348c - rustc_middle::ty::fold::TypeFoldable::fold_with::h1d568ba0d9ba8a09
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/fold.rs:74:9
  33:        0x102ee8afc - rustc_middle::ty::normalize_erasing_regions::<impl rustc_middle::ty::context::TyCtxt>::normalize_erasing_regions::hc4f250aeda8b9d76
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/normalize_erasing_regions.rs:58:13
  34:        0x102ee9dec - rustc_middle::ty::normalize_erasing_regions::<impl rustc_middle::ty::context::TyCtxt>::normalize_erasing_late_bound_regions::hf602c6eb9e19a655
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/normalize_erasing_regions.rs:112:9
  35:        0x102f2c2a4 - rustc_const_eval::interpret::terminator::<impl rustc_const_eval::interpret::eval_context::InterpCx<M>>::eval_terminator::h4af56fdce5c5c777
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_const_eval/src/interpret/terminator.rs:76:21
  36:        0x102f4a164 - rustc_const_eval::interpret::step::<impl rustc_const_eval::interpret::eval_context::InterpCx<M>>::terminator::he6130a6d48b90b19
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_const_eval/src/interpret/step.rs:312:9
  37:        0x102c5d9ac - rustc_const_eval::interpret::step::<impl rustc_const_eval::interpret::eval_context::InterpCx<M>>::step::ha0fc27499a484102
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_const_eval/src/interpret/step.rs:71:9
  38:        0x102c5d9ac - miri::eval::eval_entry::{{closure}}::h5810cc380430e7ca
                               at /Users/ouz/Code/GitHub/rust/src/tools/miri/src/eval.rs:341:29
  39:        0x102e6ea30 - miri::eval::eval_entry::hb3886ee040677382
                               at /Users/ouz/Code/GitHub/rust/src/tools/miri/src/eval.rs:335:38
  40:        0x102acc368 - <miri::MiriCompilerCalls as rustc_driver::Callbacks>::after_analysis::{{closure}}::h47dfbaeb064e3774
                               at /Users/ouz/Code/GitHub/rust/src/tools/miri/src/bin/miri.rs:78:40
  41:        0x102acbd6c - rustc_interface::passes::QueryContext::enter::{{closure}}::ha7d8c04dc6b60909
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_interface/src/passes.rs:787:42
  42:        0x102aca0ec - rustc_middle::ty::context::tls::enter_context::{{closure}}::hc17f98344f622bcf
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/context.rs:1930:50
  43:        0x102aca1ac - rustc_middle::ty::context::tls::set_tlv::h80e6da773dbd83e0
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/context.rs:1914:9
  44:        0x102aca0a4 - rustc_middle::ty::context::tls::enter_context::h696299c6691d92eb
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_middle/src/ty/context.rs:1930:9
  45:        0x102acbd20 - rustc_interface::passes::QueryContext::enter::hcdddf80d42aa3963
                               at /Users/ouz/Code/GitHub/rust/compiler/rustc_interface/src/passes.rs:787:9
  46:        0x102ac5cb0 - <miri::MiriCompilerCalls as rustc_driver::Callbacks>::after_analysis::hec847b24b098d72d
                               at /Users/ouz/Code/GitHub/rust/src/tools/miri/src/bin/miri.rs:61:9
  47:        0x10cf90810 - <rustc_interface[bd25737d3859b110]::interface::Compiler>::enter::<rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}::{closure#2}, core[e78181ecd1ceeb9c]::result::Result<core[e78181ecd1ceeb9c]::option::Option<rustc_interface[bd25737d3859b110]::queries::Linker>, rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>
  48:        0x10cf8f8e8 - rustc_span[dbe5a3cbc50f2bf]::with_source_map::<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_interface[bd25737d3859b110]::interface::create_compiler_and_run<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>::{closure#1}>
  49:        0x10cf911ac - rustc_interface[bd25737d3859b110]::interface::create_compiler_and_run::<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>
  50:        0x10cf7ed80 - <scoped_tls[e8ecb510089da108]::ScopedKey<rustc_span[dbe5a3cbc50f2bf]::SessionGlobals>>::set::<rustc_interface[bd25737d3859b110]::interface::run_compiler<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>
  51:        0x10cfacd6c - std[4c7b4fc7f8c44cca]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[bd25737d3859b110]::util::run_in_thread_pool_with_globals<rustc_interface[bd25737d3859b110]::interface::run_compiler<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>
  52:        0x10cfa2b60 - std[4c7b4fc7f8c44cca]::panicking::try::<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, core[e78181ecd1ceeb9c]::panic::unwind_safe::AssertUnwindSafe<<std[4c7b4fc7f8c44cca]::thread::Builder>::spawn_unchecked_<rustc_interface[bd25737d3859b110]::util::run_in_thread_pool_with_globals<rustc_interface[bd25737d3859b110]::interface::run_compiler<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>::{closure#1}::{closure#0}>>
  53:        0x10cfa4060 - <<std[4c7b4fc7f8c44cca]::thread::Builder>::spawn_unchecked_<rustc_interface[bd25737d3859b110]::util::run_in_thread_pool_with_globals<rustc_interface[bd25737d3859b110]::interface::run_compiler<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>::{closure#1} as core[e78181ecd1ceeb9c]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  54:        0x1044553a8 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h3a51253c442e9fd2
  55:        0x10445cf80 - std::sys::unix::thread::Thread::new::thread_start::hca7e919e365a1d36
  56:        0x1b385c26c - __pthread_deallocate

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.64.0-dev running on aarch64-apple-darwin

query stack during panic:
#0 [try_normalize_generic_arg_after_erasing_regions] normalizing `<[closure@tabula.rs:24:19: 24:22] as core::ops::function::FnOnce<(&S,)>>::Output`
end of query stack
error: internal compiler error: no errors encountered even though `delay_span_bug` issued

error: internal compiler error: VecMap([(OpaqueTypeKey { def_id: DefId(0:7 ~ tabula[475d]::Alias::{opaque#0}), substs: ['_#0r] }, OpaqueTypeDecl { hidden_type: OpaqueHiddenType { span: no-location (#0), ty: &S }, origin: TyAlias })])
  |
  = note: delayed at compiler/rustc_infer/src/infer/opaque_types/table.rs:50:26

thread 'rustc' panicked at 'Box<dyn Any>', compiler/rustc_errors/src/lib.rs:1426:13
stack backtrace:
   0:        0x104436658 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h502b9907255a9020
   1:        0x1044c1c58 - core::fmt::write::h1312fa7bb85e0d03
   2:        0x104467b54 - std::io::Write::write_fmt::hdc03145f6f1e9dcd
   3:        0x1044364ac - std::sys_common::backtrace::print::h3f2486f04aea89c9
   4:        0x10445fc70 - std::panicking::default_hook::{{closure}}::haa37fd6bee37c759
   5:        0x10445fa18 - std::panicking::default_hook::hc228b3d9e7765ab2
   6:        0x10cf9e394 - rustc_driver[6168a678ad3ae7e8]::DEFAULT_HOOK::{closure#0}::{closure#0}
   7:        0x104460158 - std::panicking::rust_panic_with_hook::h780d45e68728c0ed
   8:        0x110fb31e4 - std[4c7b4fc7f8c44cca]::panicking::begin_panic::<rustc_errors[c285405409cce5f9]::ExplicitBug>::{closure#0}
   9:        0x110fb319c - std[4c7b4fc7f8c44cca]::sys_common::backtrace::__rust_end_short_backtrace::<std[4c7b4fc7f8c44cca]::panicking::begin_panic<rustc_errors[c285405409cce5f9]::ExplicitBug>::{closure#0}, !>
  10:        0x1112e7314 - std[4c7b4fc7f8c44cca]::panicking::begin_panic::<rustc_errors[c285405409cce5f9]::ExplicitBug>
  11:        0x110fbc4f0 - std[4c7b4fc7f8c44cca]::panic::panic_any::<rustc_errors[c285405409cce5f9]::ExplicitBug>
  12:        0x110fbeab4 - <rustc_errors[c285405409cce5f9]::HandlerInner>::flush_delayed::<alloc[8dbf09e20a862c28]::vec::Vec<rustc_errors[c285405409cce5f9]::diagnostic::Diagnostic>, &str>
  13:        0x110fab9f4 - <rustc_errors[c285405409cce5f9]::HandlerInner as core[e78181ecd1ceeb9c]::ops::drop::Drop>::drop
  14:        0x10cfe26ac - core[e78181ecd1ceeb9c]::ptr::drop_in_place::<rustc_errors[c285405409cce5f9]::Handler>
  15:        0x10cfe4a94 - core[e78181ecd1ceeb9c]::ptr::drop_in_place::<rustc_session[7b790e6398402969]::parse::ParseSess>
  16:        0x10cfca214 - core[e78181ecd1ceeb9c]::ptr::drop_in_place::<alloc[8dbf09e20a862c28]::rc::Rc<rustc_session[7b790e6398402969]::session::Session>>
  17:        0x10cfed760 - core[e78181ecd1ceeb9c]::ptr::drop_in_place::<rustc_interface[bd25737d3859b110]::interface::Compiler>
  18:        0x10cf8fc14 - rustc_span[dbe5a3cbc50f2bf]::with_source_map::<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_interface[bd25737d3859b110]::interface::create_compiler_and_run<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>::{closure#1}>
  19:        0x10cf911ac - rustc_interface[bd25737d3859b110]::interface::create_compiler_and_run::<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>
  20:        0x10cf7ed80 - <scoped_tls[e8ecb510089da108]::ScopedKey<rustc_span[dbe5a3cbc50f2bf]::SessionGlobals>>::set::<rustc_interface[bd25737d3859b110]::interface::run_compiler<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>
  21:        0x10cfacd6c - std[4c7b4fc7f8c44cca]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[bd25737d3859b110]::util::run_in_thread_pool_with_globals<rustc_interface[bd25737d3859b110]::interface::run_compiler<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>
  22:        0x10cfa2b60 - std[4c7b4fc7f8c44cca]::panicking::try::<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, core[e78181ecd1ceeb9c]::panic::unwind_safe::AssertUnwindSafe<<std[4c7b4fc7f8c44cca]::thread::Builder>::spawn_unchecked_<rustc_interface[bd25737d3859b110]::util::run_in_thread_pool_with_globals<rustc_interface[bd25737d3859b110]::interface::run_compiler<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>::{closure#1}::{closure#0}>>
  23:        0x10cfa4060 - <<std[4c7b4fc7f8c44cca]::thread::Builder>::spawn_unchecked_<rustc_interface[bd25737d3859b110]::util::run_in_thread_pool_with_globals<rustc_interface[bd25737d3859b110]::interface::run_compiler<core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>, rustc_driver[6168a678ad3ae7e8]::run_compiler::{closure#1}>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>::{closure#0}, core[e78181ecd1ceeb9c]::result::Result<(), rustc_errors[c285405409cce5f9]::ErrorGuaranteed>>::{closure#1} as core[e78181ecd1ceeb9c]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  24:        0x1044553a8 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h3a51253c442e9fd2
  25:        0x10445cf80 - std::sys::unix::thread::Thread::new::thread_start::hca7e919e365a1d36
  26:        0x1b385c26c - __pthread_deallocate

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.64.0-dev running on aarch64-apple-darwin

query stack during panic:
end of query stack
thread panicked while panicking. aborting.
[2]    43547 abort      ./miri run tabula.rs

RalfJung · 2022-08-22T22:46:56Z

@ouz-a discussion in closed MRs tends to get lost, let's discuss in rust-lang/miri#2433.

rust-highfive assigned oli-obk Jul 17, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 17, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2022

ouz-a mentioned this pull request Jul 17, 2022

ICE: TAIT issue-96572-unconstrained-upvar.rs with edition=2021 #99363

Closed

oli-obk reviewed Jul 18, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

oli-obk reviewed Jul 18, 2022

View reviewed changes

compiler/rustc_infer/src/infer/mod.rs Outdated Show resolved Hide resolved

ouz-a force-pushed the issue_57961 branch from c5050b8 to 8267ad7 Compare July 18, 2022 17:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 19, 2022

ouz-a added 2 commits July 20, 2022 12:43

take opaq types

7c0fb38

use def_id

64dc377

ouz-a force-pushed the issue_57961 branch from 8267ad7 to 64dc377 Compare July 20, 2022 09:51

ouz-a requested a review from oli-obk July 20, 2022 09:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 20, 2022

Dylan-DPC mentioned this pull request Jul 20, 2022

Rollup of 7 pull requests #99506

Merged

bors merged commit eecfdfb into rust-lang:master Jul 20, 2022

rustbot added this to the 1.64.0 milestone Jul 20, 2022

aliemjay mentioned this pull request Jul 24, 2022

ICE on nested RPIT: cannot prove CoerceUnsized predicate #99642

Closed

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 28, 2022

Rollup merge of rust-lang#99714 - ouz-a:issue_57961, r=oli-obk

8d87cd0

Fix regression introduced with rust-lang#99383 Fixes rust-lang#99642

Dylan-DPC mentioned this pull request Jul 28, 2022

Rollup of 5 pull requests #99847

Closed

oli-obk mentioned this pull request Jul 28, 2022

ICE: Failed to normalize <[closure] as std::ops::FnOnce<(&S,)>>::Output rust-lang/miri#2433

Closed

Dylan-DPC mentioned this pull request Jul 28, 2022

Rollup of 5 pull requests #99849

Merged

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 28, 2022

Rollup merge of rust-lang#99714 - ouz-a:issue_57961, r=oli-obk

91b8b9b

Fix regression introduced with rust-lang#99383 Fixes rust-lang#99642

This was referenced Jul 28, 2022

TAIT: it's possible to impl a trait for a tait by using projections #99840

Closed

Check for opaque types behind projections #99857

Closed

bjorn3 reviewed Jul 31, 2022

View reviewed changes

RalfJung mentioned this pull request Aug 23, 2022

help with a Miri ICE #100918

Closed

ouz-a mentioned this pull request Aug 24, 2022

Prevent MIRI ICE by bubbling up #100967

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Formalize defining_use_anchor #99383

Formalize defining_use_anchor #99383

ouz-a commented Jul 17, 2022

compiler-errors commented Jul 17, 2022

oli-obk left a comment

ouz-a commented Jul 18, 2022

This comment has been minimized.

oli-obk commented Jul 18, 2022

bors commented Jul 18, 2022

bors commented Jul 19, 2022

oli-obk commented Jul 20, 2022

bors commented Jul 20, 2022

RalfJung commented Jul 31, 2022

bjorn3 Jul 31, 2022 •

edited

Loading

RalfJung Aug 22, 2022

ouz-a Aug 22, 2022

ouz-a commented Aug 22, 2022

RalfJung commented Aug 22, 2022

Formalize defining_use_anchor #99383

Formalize defining_use_anchor #99383

Conversation

ouz-a commented Jul 17, 2022

compiler-errors commented Jul 17, 2022

oli-obk left a comment

Choose a reason for hiding this comment

ouz-a commented Jul 18, 2022

This comment has been minimized.

oli-obk commented Jul 18, 2022

bors commented Jul 18, 2022

bors commented Jul 19, 2022

oli-obk commented Jul 20, 2022

bors commented Jul 20, 2022

RalfJung commented Jul 31, 2022

bjorn3 Jul 31, 2022 • edited Loading

Choose a reason for hiding this comment

RalfJung Aug 22, 2022

Choose a reason for hiding this comment

ouz-a Aug 22, 2022

Choose a reason for hiding this comment

ouz-a commented Aug 22, 2022

RalfJung commented Aug 22, 2022

bjorn3 Jul 31, 2022 •

edited

Loading