-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: omit suffixes in const generics (e.g. 1_i32
)
#99393
feat: omit suffixes in const generics (e.g. 1_i32
)
#99393
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
b7be558
to
c39826e
Compare
This comment has been minimized.
This comment has been minimized.
@petrochenkov CI finally passed |
This PR removes types from const generic arguments not only in type mismatch errors (where types are the same), but in pretty much all pretty-printed types. The result seems fine though (except for inferred constants maybe, like r=me after squashing commits into one. |
@petrochenkov what should I do now? Add this extra flag to
What does it mean? Why should I squash the commits manually? |
No, the PR seems fine as is.
It means I (or someone else on my behalf) will approve this PR after the commits are squashed. |
@petrochenkov but bors squashes automatically... |
Squashing can actually be made by the merge bot, but the commit messages are suboptimal. |
@petrochenkov I've thought |
@petrochenkov after merging to |
If it's true that's good, I tried bors squash once (?) when it was introduced and, IIRC, it did something wrong back then.
Time? |
…t-generic-suffixes, r=petrochenkov feat: omit suffixes in const generics (e.g. `1_i32`) Closes rust-lang#99255
…t-generic-suffixes, r=petrochenkov feat: omit suffixes in const generics (e.g. `1_i32`) Closes rust-lang#99255
…t-generic-suffixes, r=petrochenkov feat: omit suffixes in const generics (e.g. `1_i32`) Closes rust-lang#99255
…t-generic-suffixes, r=petrochenkov feat: omit suffixes in const generics (e.g. `1_i32`) Closes rust-lang#99255
Bors uses the PR body in the description of the merge commit that it pushes to master, but that is still a merge commit with the unsquashed set of commits as the commit parent. As you can see in the rollup attempts opened since this PR was r+'ed, bors didn't squash anything. I think bors squash only does it's thing if it this PR is not rolled up. Anyways, in the future, I don't think it's necessary to include three more "test: XYZ" commits on top of the commit that does the actual change. |
…t-generic-suffixes, r=petrochenkov feat: omit suffixes in const generics (e.g. `1_i32`) Closes rust-lang#99255
8530407
to
ef620c3
Compare
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
Some changes occurred in compiler/rustc_codegen_gcc cc @antoyo Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
ef620c3
to
9428f2a
Compare
@compiler-errors I've squashed the commits |
Thanks! @bors r=petrochenkov |
Rollup of 6 pull requests Successful merges: - rust-lang#98174 (Rename `<*{mut,const} T>::as_{const,mut}` to `cast_`) - rust-lang#98868 (Fix unreachable coverage generation for inlined functions) - rust-lang#99393 (feat: omit suffixes in const generics (e.g. `1_i32`)) - rust-lang#99423 (Group CSS font rule) - rust-lang#99539 (Improve suggestions for returning binding) - rust-lang#99579 (Add same warning to Result::expect as Result::unwrap) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
@petrochenkov I see the rollup is merged. What should I do now? |
You should never push to a branch that is in an open rollup. Now you'll have to make a new PR with the bits that you pushed since the rollup was created. |
@bors r- |
@RalfJung I changed nothing, just squashed the commits as I've been told by @compiler-errors. Can I just close this PR now? |
Yeah if everything landed you can close the PR. @compiler-errors didn't actually ask you to squash this PR, so I guess there was some miscommunication here. (They just said "in the future, I don't think it's necessary to include [...]" but they didn't say "please squash this PR", as far as I can see.) Generally, don't touch the PR after it has been Looks like squashing and rollups don't work together, I'll report that as a bug for bors. |
Merged in rust-lang-ci@e7a9c11 |
Closes #99255