Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize core::task::ready! #99419

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Stabilize core::task::ready! #99419

merged 1 commit into from
Jul 19, 2022

Conversation

yoshuawuyts
Copy link
Member

This stabilizes core::task::ready! for Rust 1.64. The FCP for stabilization was just completed here #70922 (comment). Thanks!

Closes #70922

cc/ @rust-lang/libs-api

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 18, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 18, 2022

📌 Commit 454313f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2022
@matthiaskrgr
Rollup merge of rust-lang#99419 - yoshuawuyts:stabilize-task-ready, r…
f3816dd 
…=Mark-Simulacrum

Stabilize `core::task::ready!`

This stabilizes `core::task::ready!` for Rust 1.64. The FCP for stabilization was just completed here rust-lang#70922 (comment). Thanks!

Closes rust-lang#70922

cc/ `@rust-lang/libs-api`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 18, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2022
@bors
Auto merge of rust-lang#99462 - matthiaskrgr:rollup-ihhwaru, r=matthi…
a289cfc 
…askrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#98028 (Add E0790 as more specific variant of E0283)
 - rust-lang#99384 (use body's param-env when checking if type needs drop)
 - rust-lang#99401 (Avoid `Symbol` to `&str` conversions)
 - rust-lang#99419 (Stabilize `core::task::ready!`)
 - rust-lang#99435 (Revert "Stabilize $$ in Rust 1.63.0")
 - rust-lang#99438 (Improve suggestions for `NonZeroT` <- `T` coercion error)
 - rust-lang#99441 (Update mdbook)
 - rust-lang#99453 (:arrow_up: rust-analyzer)
 - rust-lang#99457 (use `par_for_each_in` in `par_body_owners` and `collect_crate_mono_items`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7d75497 into rust-lang:master Jul 19, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 19, 2022
@yoshuawuyts yoshuawuyts deleted the stabilize-task-ready branch July 20, 2022 08:23
@joshtriplett joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for core::task::ready! macro
7 participants
@yoshuawuyts @rustbot @rust-highfive @Mark-Simulacrum @bors @kennytm @joshtriplett