Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use ICF (identical code folding) for building rustc" #99442

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Revert "Use ICF (identical code folding) for building rustc" #99442

merged 1 commit into from
Jul 19, 2022
+1 −12

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jul 18, 2022

Reverts #99062

Fixes: #99440

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 18, 2022
@rust-highfive
Copy link
Collaborator

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2022
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 18, 2022

r? @jyn514

@rust-highfive rust-highfive assigned jyn514 and unassigned pietroalbini Jul 18, 2022
@Kobzol Kobzol mentioned this pull request Jul 18, 2022
Closed
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented Jul 18, 2022

📌 Commit 45575d2 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2022
@matthiaskrgr
Copy link
Member

@bors p=20
(moving before the rollups)

@bors
Copy link
Contributor

bors commented Jul 18, 2022

⌛ Testing commit 45575d2 with merge 475aec1...

@bors
Copy link
Contributor

bors commented Jul 19, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 475aec1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 19, 2022
@bors bors merged commit 475aec1 into rust-lang:master Jul 19, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 19, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (475aec1): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -0.4% -0.4% 1
Improvements 🎉
(secondary)		 -2.5% -2.6% 3
All 😿🎉 (primary) -0.4% -0.4% 1

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 1.8% 2.9% 15
Regressions 😿
(secondary)		 3.5% 4.8% 4
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.3% -2.9% 16
All 😿🎉 (primary) 1.8% 2.9% 15

Cycles

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 2.9% 7.0% 17
Regressions 😿
(secondary)		 3.5% 7.4% 38
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 2.9% 7.0% 17

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@Kobzol Kobzol mentioned this pull request Jul 19, 2022
Merged
@Kobzol Kobzol deleted the revert-99062-lld-icf branch July 19, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

rustup linux rustc executable not executable (symbol lookup error)
9 participants
@Kobzol @rust-highfive @Mark-Simulacrum @bors @matthiaskrgr @rust-timer @pietroalbini @jyn514 @rustbot