-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MIPS VZ ISA extension #99443
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
@rustbot reroll |
r? rust-lang/compiler |
1 similar comment
r? rust-lang/compiler |
r? @nagisa (looks like you know what's up from the linked issue) |
This would benefit from a test of some sort verifying that r=me even if you decide to not pursue adding any tests. |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c97922d): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Link to relevant LLVM line where virt extension is specified
This has been tested on mips-unknown-linux-musl with a target-cpu that is >= MIPS32 5 and
target-features=+virt
. The example was checked in a disassembler to ensure the correct assembly sequence was being generated using the virtualization instructions.Needed additional work:
Example docs for later:
If the above is good I can also submit a PR for that if there's interest in documenting it while it's still unstable. Otherwise that can be dropped, I just wrote it before realizing it was possibly not a good idea.
Relevant to #44839