remove commit_unconditionally

[lcnr]

commit_unconditionally is a noop unless we somehow inspect the current state of our snapshot. The only thing which does that is the leak check which was only used in one place where commit_if_ok is probably at least as, or even more, correct.

r? rust-lang/types

[lcnr]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit b81e74c with merge b33c47c614d06d8fff16bf03468f45661920b716...

[bors]

☀️ Try build successful - checks-actions
Build commit: b33c47c614d06d8fff16bf03468f45661920b716 (b33c47c614d06d8fff16bf03468f45661920b716)

[rust-timer]

Queued b33c47c614d06d8fff16bf03468f45661920b716 with parent a7468c6, future comparison URL.

[rust-timer]

Finished benchmarking commit (b33c47c614d06d8fff16bf03468f45661920b716): comparison url.

Instruction count

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.5%	-1.0%	8
Improvements 🎉 (secondary)	-0.8%	-0.8%	1
All 😿🎉 (primary)	-0.5%	-1.0%	8

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	9.5%	9.5%	1
Improvements 🎉 (primary)	-5.8%	-5.8%	1
Improvements 🎉 (secondary)	-2.4%	-2.6%	2
All 😿🎉 (primary)	-5.8%	-5.8%	1

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[jackh726]

@bors r+

[bors]

📌 Commit b81e74c has been approved by jackh726

It is now in the queue for this repository.

[bors]

⌛ Testing commit b81e74c with merge b759b2e...

[bors]

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing b759b2e to master...

[rust-timer]

Finished benchmarking commit (b759b2e): comparison url.

Instruction count

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.5%	-1.0%	8
Improvements 🎉 (secondary)	-0.8%	-0.8%	1
All 😿🎉 (primary)	-0.5%	-1.0%	8

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩

2. number of relevant changes ↩