-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #99562
Closed
Closed
Rollup of 7 pull requests #99562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety` feature that stabilized in 1.63.0.
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Add `special_module_name` lint Declaring `lib` as a module is one of the most common beginner mistakes when trying to setup a binary and library target in the same crate. `special_module_name` lints against it, as well as `mod main;` ``` warning: found module declaration for main.rs --> $DIR/special_module_name.rs:4:1 | LL | mod main; | ^^^^^^^^^ | = note: a binary crate cannot be used as library warning: found module declaration for lib.rs --> $DIR/special_module_name.rs:1:1 | LL | mod lib; | ^^^^^^^^ | = note: `#[warn(special_module_name)]` on by default = note: lib.rs is the root of this crate's library target = help: to refer to it from other targets, use the library's name as the path ``` Note that the help message is not the best in that it doesn't provide an example of an import path (`the_actual_crate_name::`), and doesn't check whether the current file is part of a library/binary target to provide more specific error messages. I'm not sure where this lint would have to be run to access that information.
std: use futex-based locks on Fuchsia This switches `Condvar` and `RwLock` to the futex-based implementation currently used on Linux and some BSDs. Additionally, `Mutex` now has its own, priority-inheriting implementation based on the mutex in Fuchsia's `libsync`. It differs from the original in that it panics instead of aborting when reentrant locking is detected. ``@rustbot`` ping fuchsia r? ``@m-ou-se``
Add `PhantomData` marker for dropck to `BTreeMap` closes rust-lang#99408
Fix the stable version of `AsFd for Arc<T>` and `Box<T>` These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety` feature that stabilized in 1.63.0.
…, r=oli-obk Normalize the arg spans to be within the call span Makes more sense to point out the arg's span, and not the expression inside the macro
…rrors Add regression test for rust-lang#52304 Closes rust-lang#52304 r? `@compiler-errors` Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Rewrite `orphan_check_trait_ref` to use a `TypeVisitor` The current impl is far more confusing than it has any right to be ✨ r? rust-lang/types
rustbot
added
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Jul 21, 2022
The job Click to see the possible cause of the failure (guessed by this bot)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
special_module_name
lint #94467 (Addspecial_module_name
lint)PhantomData
marker for dropck toBTreeMap
#99413 (AddPhantomData
marker for dropck toBTreeMap
)AsFd for Arc<T>
andBox<T>
#99523 (Fix the stable version ofAsFd for Arc<T>
andBox<T>
)orphan_check_trait_ref
to use aTypeVisitor
#99552 (Rewriteorphan_check_trait_ref
to use aTypeVisitor
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup