Use full type name instead of just saying impl Trait in "captures lifetime" error
#99748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
compiler-errors
commented
Jul 26, 2022
| @@ -1,4 +1,4 @@ | |||
| error[E0700]: hidden type for `impl Trait` captures lifetime that does not appear in bounds | |||
| error[E0700]: hidden type for `Opaque(DefId(0:11 ~ impl_trait_captures[1afc]::foo::{opaque#0}), [ReStatic, T, ReEarlyBound(0, 'a)])` captures lifetime that does not appear in bounds | |||
There was a problem hiding this comment.
side-note that this test uses -Zverbose, so not my fault and don't think it needs fixing.
|
@bors r+ |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 26, 2022
…rinting, r=fee1-dead Use full type name instead of just saying `impl Trait` in "captures lifetime" error I think this is very useful, especially when there's >1 `impl Trait`, and it just means passing around a bit more info that we already have access to.
This was referenced Jul 26, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 26, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#99618 (handle consts with param/infer in `const_eval_resolve` better) - rust-lang#99666 (Restore `Opaque` behavior to coherence check) - rust-lang#99692 (interpret, ptr_offset_from: refactor and test too-far-apart check) - rust-lang#99739 (Remove erroneous E0133 code from an error message.) - rust-lang#99748 (Use full type name instead of just saying `impl Trait` in "captures lifetime" error) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is very useful, especially when there's >1
impl Trait, and it just means passing around a bit more info that we already have access to.