Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF ONLY] Revert "Prefer visibility map parents that are not doc(hidden) first" #99819

Closed
wants to merge 1 commit into from

Conversation

compiler-errors
Copy link
Member

Reverts #99698 for perf reasons

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 27, 2022
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 27, 2022
@bors
Copy link
Collaborator

bors commented Jul 27, 2022

⌛ Trying commit 63fe792 with merge d7e8cb0e9cbee833a6d90da5036b4cf2328f5d7e...

@bors
Copy link
Collaborator

bors commented Jul 27, 2022

☀️ Try build successful - checks-actions
Build commit: d7e8cb0e9cbee833a6d90da5036b4cf2328f5d7e (d7e8cb0e9cbee833a6d90da5036b4cf2328f5d7e)

@rust-timer
Copy link
Collaborator

Queued d7e8cb0e9cbee833a6d90da5036b4cf2328f5d7e with parent da5b546, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d7e8cb0e9cbee833a6d90da5036b4cf2328f5d7e): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-0.5% -0.8% 9
Improvements 🎉
(secondary)
-1.7% -2.8% 6
All 😿🎉 (primary) -0.5% -0.8% 9

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-1.5% -1.8% 2
Improvements 🎉
(secondary)
-2.6% -3.0% 5
All 😿🎉 (primary) -1.5% -1.8% 2

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
3.3% 3.3% 1
Improvements 🎉
(primary)
-3.0% -3.0% 1
Improvements 🎉
(secondary)
-2.8% -2.9% 2
All 😿🎉 (primary) -3.0% -3.0% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 27, 2022
@compiler-errors
Copy link
Member Author

cc @pnkfelix

@compiler-errors
Copy link
Member Author

Experiment is over so closing.

@pietroalbini pietroalbini deleted the revert-99698-no-doc-hidden branch November 13, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants