-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ipv6Addr::is_unicast_global to check for unicast global scope rebase #99947
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
@rustbot label +T-libs-api |
@bors r+ rollup This makes rough sense to me, though I'm not super familiar with this area of networking. I think given this is all unstable we can merge this in and make sure these are what we want during stabilization. |
📌 Commit 7c660b47ef98e7ad5c5fa81bbfb873d24d6c3df0 has been approved by It is now in the queue for this repository. |
…se, r=Mark-Simulacrum Rework Ipv6Addr::is_global to check for global reachability rather than global scope - rebase Rebasing of pull request rust-lang#86634 off of master to try and get the feature "ip" stabilized. I also found a test failure in the rebase that is_global was considering the benchmark space to be globally reachable. This is related to my other rebasing pull request rust-lang#99947
☔ The latest upstream changes (presumably #100881) made this pull request unmergeable. Please resolve the merge conflicts. |
7c660b4
to
87991d5
Compare
@Mark-Simulacrum I did the rebase of https://github.com/chotchki/rust/tree/unicast_global but had to recreate the branch and as a result the GitHub pull request history looks really strange to me. Should I recreate the pull request? |
Rebasing of pull request #85696 off of master to try and get the feature "ip" stabilized.