-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always create elided lifetimes, even if inferred. #99953
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
I don't know if @michaelwoerister is available for review, but this PR fixes the p-critical nightly regression that Maybe @rust-lang/types could also take a look if they have the time ? (though this is very early in the pipeline...) |
Yeah, I don't really know the code involved here. @cjgillot, do you have a reviewer in mind? |
Maybe @petrochenkov, but they're busy ? Since they reviewed #99728 which introduced the issue, as well as many/all of the initial PRs for AST lifetime resolution. |
I'll look later today. |
r? @petrochenkov @bors r+ |
Fixes a P-critical issue: @bors p=1 |
⌛ Testing commit ec3f307 with merge f7eabaed14599cd46ad3fa8de3157dd6779ba03b... |
💔 Test failed - checks-actions |
@bors retry network issue on dist-aarch64-msvc builder |
This comment was marked as outdated.
This comment was marked as outdated.
@bors retry (same problem) |
That was the bot taking a while to post the status here after the build failed :) (indeed it's confusing) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (6f18f0a): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
PathSource
gives the context in which a path is encountered. The samePathSource
is used for the full path and theQSelf
part.Therefore, we can only rely on
PathSource
to know whether typechecking will be able to infer the lifetimes, not whether we need to insert them at all.Fixes #99949