Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always create elided lifetimes, even if inferred. #99953

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

cjgillot
Copy link
Contributor

PathSource gives the context in which a path is encountered. The same PathSource is used for the full path and the QSelf part.

Therefore, we can only rely on PathSource to know whether typechecking will be able to infer the lifetimes, not whether we need to insert them at all.

Fixes #99949

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 30, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2022
@lqd
Copy link
Member

lqd commented Aug 3, 2022

I don't know if @michaelwoerister is available for review, but this PR fixes the p-critical nightly regression that sqlx is hitting.

Maybe @rust-lang/types could also take a look if they have the time ? (though this is very early in the pipeline...)

@michaelwoerister
Copy link
Member

Yeah, I don't really know the code involved here. @cjgillot, do you have a reviewer in mind?

@lqd
Copy link
Member

lqd commented Aug 3, 2022

Maybe @petrochenkov, but they're busy ? Since they reviewed #99728 which introduced the issue, as well as many/all of the initial PRs for AST lifetime resolution.

@petrochenkov
Copy link
Contributor

I'll look later today.

@petrochenkov petrochenkov self-assigned this Aug 3, 2022
@petrochenkov
Copy link
Contributor

r? @petrochenkov @bors r+

@bors
Copy link
Contributor

bors commented Aug 3, 2022

📌 Commit ec3f307 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2022
@lqd
Copy link
Member

lqd commented Aug 3, 2022

Fixes a P-critical issue:

@bors p=1

@bors
Copy link
Contributor

bors commented Aug 4, 2022

⌛ Testing commit ec3f307 with merge f7eabaed14599cd46ad3fa8de3157dd6779ba03b...

@bors
Copy link
Contributor

bors commented Aug 4, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 4, 2022
@lqd
Copy link
Member

lqd commented Aug 4, 2022

Couldn't resolve host name (Could not resolve host: crates.io)

@bors retry network issue on dist-aarch64-msvc builder

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2022
@rust-log-analyzer

This comment was marked as outdated.

@michaelwoerister
Copy link
Member

michaelwoerister commented Aug 4, 2022

@bors retry (same problem)

@lqd
Copy link
Member

lqd commented Aug 4, 2022

That was the bot taking a while to post the status here after the build failed :)

(indeed it's confusing)

@bors
Copy link
Contributor

bors commented Aug 4, 2022

⌛ Testing commit ec3f307 with merge 6f18f0a...

@bors
Copy link
Contributor

bors commented Aug 4, 2022

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 6f18f0a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 4, 2022
@bors bors merged commit 6f18f0a into rust-lang:master Aug 4, 2022
@rustbot rustbot added this to the 1.64.0 milestone Aug 4, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6f18f0a): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-1.2% -1.2% 1
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
2.1% 2.1% 1
Regressions 😿
(secondary)
2.8% 2.8% 1
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-2.6% -2.8% 2
All 😿🎉 (primary) 2.1% 2.1% 1

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)
2.1% 2.1% 1
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-2.7% -2.7% 1
All 😿🎉 (primary) 2.1% 2.1% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@cjgillot cjgillot deleted the in-path-always branch August 4, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with lifetimes when using Foo as Trait and Trait has an associated lifetime
9 participants