Support searching for and demangling symbols #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an API for demangling a stream of data which consists of a mix
of mangled and non-mangled symbols. This is gated behind a new Cargo
feature ("std") since the new API uses I/O traits and allocates memory.
This API is broadly useful for any downstream users that are processing
streams with interleaved symbols (e.g., perf script output) and don't
want to filter down ahead of time. Previously the best option for this
(to my knowledge) was either shelling out to the `rustfilt` binary or
copying an implementation much like it.
The implementation added in this commit is roughly 2x faster than that
in the rustfilt binary today; if this is accepted moving rustfilt to use
this will make sense.
|
Fuzz target failure looks unrelated to this PR - probably upstream change? I ran the fuzzing locally and it seems to be fine. |
alexcrichton
approved these changes
Mar 20, 2023
|
Alright, CI is passing. |
alexcrichton
approved these changes
Mar 22, 2023
|
I'll probably look into optimizing further since waiting 20+ seconds for demangling isn't fun, but in any case I think we can probably merge this - did you want me to do merge + publish for you? I technically have the right access through infra but the ownership for this crate feels somewhat unclear today. |
|
Sure yeah that'd be appreciated! |
|
Alright, merged this and publish 0.1.22 with the new APIs. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an API for demangling a stream of data which consists of a mix of mangled and non-mangled symbols. This is gated behind a new Cargo feature ("std") since the new API uses I/O traits and allocates memory.
This API is broadly useful for any downstream users that are processing streams with interleaved symbols (e.g., perf script output) and don't want to filter down ahead of time. Previously the best option for this (to my knowledge) was either shelling out to the
rustfiltbinary or copying an implementation much like it.The implementation added in this commit is roughly 2x faster than that in the rustfilt binary today (on a test input I have 40 seconds -> 20 seconds); if this is accepted moving rustfilt to use this will probably make sense.