Directly write to output instead of local String buffer #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous measurements showed this to be a net loss in performance, but further investigation shows that is likely to be a result of increased syscalls in the test benchmark. Adjusting the benchmark to buffer the output (e.g., with std::io::BufWriter) makes this a win, around 16% faster. Documentation on demangle_stream is updated to recommend buffering the output writer.
Mark-Simulacrum
force-pushed
the
direct-write
branch
from
206a6ac to
13be70d
Compare
alexcrichton
approved these changes
Apr 5, 2023
|
I'll go ahead and make a point release if you have no objections with this change? |
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous measurements showed this to be a net loss in performance, but further investigation shows that is likely to be a result of increased syscalls in the test benchmark. Adjusting the benchmark to buffer the output (e.g., with std::io::BufWriter) makes this a win, around 16% faster.
Documentation on demangle_stream is updated to recommend buffering the output writer.