Skip to content

Move the documentation related to ./x.py from https://forge.rust-lang.org #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rajcspsg opened this issue May 10, 2018 · 9 comments
Closed

Comments

@rajcspsg
Copy link
Contributor

As per discussion #84 (comment) create a new documentation for ./x.py.

Copy the contents from link https://forge.rust-lang.org/x-py.html into the new file.

@rajcspsg rajcspsg mentioned this issue May 10, 2018
@mark-i-m
Copy link
Member

It would be good to systematically move over relevant stuff from there. A PR on this repo should probably be accompanied by a PR on https://github.com/rust-lang-nursery/rust-forge

@mark-i-m
Copy link
Member

@rajcspsg Did you want to work on this?

@rajcspsg
Copy link
Contributor Author

@mark-i-m - my pleasure :)
I've to copy the x-py.md correct?

@mark-i-m
Copy link
Member

I think that would be a great start. Some of the things on the forge page are already in the rustc-guide (https://rust-lang-nursery.github.io/rustc-guide/how-to-build-and-run.html), so we should try to avoid duplicating content. I think we can add the content from the forge page to the existing chapter in the guide. (TBH, I haven't read the forge page, but let me know if you get stuck :) )

@mark-i-m
Copy link
Member

mark-i-m commented Jun 4, 2018

Ping @rajcspsg

@rajcspsg
Copy link
Contributor Author

rajcspsg commented Sep 7, 2018

@mark-i-m my apologies for delay. Finally I have created PR here #195.

One pending item is link the respective links here. https://github.com/rust-lang-nursery/rustc-guide/blob/986ab9e857876a712bcd1a0644aaf89775b909d4/src/what-is-x-py.md at very last line to other documents(like clean, build , document, test and install distribution for rustc).

Please review and let me know your comments.

@mark-i-m
Copy link
Member

mark-i-m commented Sep 7, 2018

Nice! I'll probably come around to this next week. Thanks :)

@rajcspsg
Copy link
Contributor Author

rajcspsg commented Oct 5, 2018

@mark-i-m we can close this ticket correct?

@mark-i-m
Copy link
Member

Yep! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants