Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify why Salsa is mentioned #1867

Open
Arthur-Milchior opened this issue Jan 28, 2024 · 2 comments
Open

Clarify why Salsa is mentioned #1867

Arthur-Milchior opened this issue Jan 28, 2024 · 2 comments
Labels
A-incr-comp Area: incremental compilation A-query-system Area: query system E-medium Difficulty: might require some prior knowledge or code reading I-confusing Issue: info is confusing to readers T-compiler Relevant to compiler team

Comments

@Arthur-Milchior
Copy link
Contributor

I admit I'm quite confused by the part of the book about Salsa.
Not the content, it feels relatively clear after the previous sections explains in details the idea of the algoritm.
But why it is mentioned.

First, in incremental compilation, I read

> 1 I have long wanted to rename it to the Salsa algorithm, but it never caught on. -@nikomatsakis

Then I realize in how salsa works that something is called Salsa.
So I guess the book should clarify somehow how the algorithm wannabe-name and the library are related. In particular, that the Salsa library is not an implementation of what nikomatsakis calls the Salsa algorithm, even if the talk is by the same person. I admit that it's relatively confusing here.

More importantly, I think, is, why is this section in the rustc-dev-guide if rustc does not use it. The actual implementation was linked to in the "in detail" section. So I guess the point is not to tell us the red-green algorithm is really used.
If the point is only to state "by the way, this is a clearly related topic you might be interested", I suspect you should explicitly state that, while interesting, one won't learn anything about rustc specifically in this section

@flodiebold
Copy link
Member

Salsa the library is an implementation of the Salsa algorithm. Also, the red-green algorithm (which is another name for the same thing) is used in rustc, it's just not using Salsa the library 🙂

@Arthur-Milchior
Copy link
Contributor Author

Oh. Since it is another name for the red-green algorithm, then I guess the footnote is no longer accurate.

Still, I admit that it's not clear why the rustc book mentions a library not used by rustc.

Thanks for the clarification

@jieyouxu jieyouxu added T-compiler Relevant to compiler team I-confusing Issue: info is confusing to readers A-incr-comp Area: incremental compilation A-query-system Area: query system E-medium Difficulty: might require some prior knowledge or code reading labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: incremental compilation A-query-system Area: query system E-medium Difficulty: might require some prior knowledge or code reading I-confusing Issue: info is confusing to readers T-compiler Relevant to compiler team
Projects
None yet
Development

No branches or pull requests

3 participants