Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain in more depth about keep-stage #201

Closed
nikomatsakis opened this issue Sep 11, 2018 · 4 comments
Closed

explain in more depth about keep-stage #201

nikomatsakis opened this issue Sep 11, 2018 · 4 comments
Labels
E-help-wanted Call for participation: extra help is wanted E-medium Difficulty: might require some prior knowledge or code reading

Comments

@nikomatsakis
Copy link
Contributor

#191 added some commentary about --keep-stage 1 but there is probably more to say.

@Mark-Simulacrum wrote a comment explaining some more workflows but I confess I haven't fully processed it.

It seems like we should dedicate an entire section (I'd make a new file, perosnally) to keep-stage and explain:

  • What exactly it does (e.g., what is the effect of --keep-stage 0)
  • Common workflows where it can be useful
@mark-i-m mark-i-m added E-help-wanted Call for participation: extra help is wanted E-medium Difficulty: might require some prior knowledge or code reading labels Sep 15, 2018
@dwijnand
Copy link
Member

I've so many questions for @Mark-Simulacrum about his workflows in #191 (comment):

How does x.py build --stage 1 --keep-stage 0 src/libstd "build the compiler once and only once"? Doesn't it skip compiling the stage 0 compiler and never get to compiling the stage 1 compiler?

Instead of x.py build --stage 1 src/libstd --keep-stage 1 wouldn't it be faster to do x.py build --stage 0 src/rustc? I think it is but it's missing the uplifting of rustc and sysroot into build/HOST/stage1.

Is there a difference between x.py build --stage 2 --keep-stage 0 and x.py build --stage 1? I think it's not because each stage isn't the same so it's not simply "do two dogfood iterations".

For cross-linking, my general staging discussions are happening in rust-lang/rust#57963.

@dwijnand
Copy link
Member

Perhaps a good starting point would be off of @nikomatsakis' comment: #191 (comment)

What's does --keep-stage 1 do?

@mark-i-m
Copy link
Member

Discussed a bit in rust-lang/rust#57963

@mark-i-m
Copy link
Member

mark-i-m commented Dec 6, 2019

There is more discussion in https://rust-lang.github.io/rustc-guide/building/bootstrapping.html

So I will close this issue, but feel free to reopen...

@mark-i-m mark-i-m closed this as completed Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-help-wanted Call for participation: extra help is wanted E-medium Difficulty: might require some prior knowledge or code reading
Projects
None yet
Development

No branches or pull requests

3 participants