Skip to content

documentation about feature gates #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
nikomatsakis opened this issue Mar 19, 2018 · 7 comments
Closed
4 tasks done

documentation about feature gates #98

nikomatsakis opened this issue Mar 19, 2018 · 7 comments
Labels
E-easy Difficulty: might be a good place for a beginner

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Mar 19, 2018

I find myself referencing this forge article a lot:

https://forge.rust-lang.org/feature-guide.html
EDIT (mark-i-m): this moved to https://rust-lang.github.io/rustc-guide/implementing_new_features.html

It's ok, but not great. Some things I would like to see covered in rustc-guide instead (and then perhaps remove that article):

  • how to add a feature gate in the code
    • how to add a test covering your feature gate
  • how to change for simple syntactic things
  • how to do more advanced gates by looking at sess.features.your_feature_here as a boolean
@mark-i-m
Copy link
Member

Also, how to stabilize. And then maybe we can get rid of that forge article too...

@mark-i-m mark-i-m added E-help-wanted Call for participation: extra help is wanted E-easy Difficulty: might be a good place for a beginner labels Mar 21, 2018
@rajcspsg rajcspsg mentioned this issue Apr 17, 2018
@mark-i-m mark-i-m removed the E-help-wanted Call for participation: extra help is wanted label Jan 23, 2019
@mark-i-m
Copy link
Member

how to change for simple syntactic things

@nikomatsakis Could you clarify what you mean by this? Do you mean warning cycles and future compat lints?

@alecmocatta
Copy link

For anyone else coming here from google and looking for where the above link moved to: https://rust-lang.github.io/rustc-guide/implementing_new_features.html

@mark-i-m
Copy link
Member

Thanks @alecmocatta
Updated above.

@mark-i-m
Copy link
Member

@Centril Do you happen to know what the procedure is for this (from Niko's post above):

how to change for simple syntactic things

@Centril
Copy link
Contributor

Centril commented Nov 12, 2019

@mark-i-m It's documented in https://rust-lang.github.io/rustc-guide/implementing_new_features.html :)

@mark-i-m
Copy link
Member

Oh, lol ok. I will close this issue then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Difficulty: might be a good place for a beginner
Projects
None yet
Development

No branches or pull requests

4 participants