Skip to content

Cleanup rustdoc-internals #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2022
Merged

Cleanup rustdoc-internals #1355

merged 1 commit into from
May 25, 2022

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented May 21, 2022 •
edited
Loading

  • fixed one broken link
  • updated date reference

cc #1344

@JohnTitor JohnTitor mentioned this pull request May 21, 2022
Closed
36 tasks
@JohnTitor
Copy link
Member Author

cc @rust-lang/rustdoc it'd be great if someone from the team could review this, I'm not familiar with rustdoc :)

@JohnTitor JohnTitor added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label May 21, 2022
@GuillaumeGomez
Copy link
Member

Thanks a lot for the update! :)

Let's check if I have r+ rights here:

@bors r+

@GuillaumeGomez
Copy link
Member

Ah, it's not handled by bors in here. Well, you got my approval to merge. :)

@JohnTitor
Copy link
Member Author

Thanks both! This repo needs one approval from reviewers with write access, so going to cc @rust-lang/wg-rustc-dev-guide :)

camelid
camelid approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamping as rustc-dev-guide team member, not rustdoc team member ;)

@camelid camelid merged commit 554c00e into rust-lang:master May 25, 2022
@JohnTitor JohnTitor deleted the cleanup-rustdoc-internals branch May 25, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notriddle notriddle notriddle approved these changes

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

@camelid camelid camelid approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnTitor @GuillaumeGomez @notriddle @camelid