Fix path to rustfmt in Suggested Workflows
#1462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the original is correct. There's just a bug that rustfmt doesn't get downloaded until you run a command that needs it (like EDIT: The desire is to use a pinned version of rustfmt, since rarely newer versions may format differently than the pinned version. So you don't want to use one built from scratch. |
|
Ah gotcha thanks for clarifying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was pairing with a new contributor the other day and we realized the path to
rustfmtwas wrong.I think it also might be the case that users now have to manually build stage0
rustfmtby doing./x.py build --stage 0 src/tools/rustfmt. It doesn't seem to get built when doing./x.py buildon a compiler config.