Skip to content

do an actual link to detect if it breaks in future #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2022
Merged

do an actual link to detect if it breaks in future #1517

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56fa1c6
do an actual link to detect if it breaks in future
tshepang Nov 26, 2022
4a2cbaa
accept review suggestion
tshepang Nov 26, 2022
06f90ff
accept review suggestion
tshepang Nov 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/queries/incremental-compilation-in-detail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,19 +175,19 @@ fn try_mark_green(tcx, current_node) -> bool {

true
}

// Note: The actual implementation can be found in
// compiler/rustc_query_system/src/dep_graph/graph.rs
```

> NOTE:
> The actual implementation can be found in
> [`compiler/rustc_query_system/src/dep_graph/graph.rs`][try_mark_green]

By using red-green marking we can avoid the devastating cumulative effect of
having false positives during change detection. Whenever a query is executed
in incremental mode, we first check if its already green. If not, we run
`try_mark_green()` on it. If it still isn't green after that, then we actually
invoke the query provider to re-compute the result.



## The Real World: How Persistence Makes Everything Complicated

The sections above described the underlying algorithm for incremental
Expand Down Expand Up @@ -533,5 +533,5 @@ be reusable. See <https://github.com/rust-lang/rust/issues/47389> for more
information.



[query-model]: ./query-evaluation-model-in-detail.html
[try_mark_green]: https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_query_system/dep_graph/graph.rs.html