Add a section for how to review code more easily #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
reviewed
Jan 1, 2023
|
I think I addressed all your comments :) |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 16, 2023
Update books ## rust-lang/book 1 commits in 2bd5d42c9956369132228da6409f0e68da56c51a..2cd1b5593d26dc6a03c20f8619187ad4b2485552 2023-01-12 14:47:47 UTC to 2023-01-12 14:47:47 UTC - Typo (rust-lang/book#3457) ## rust-lang/nomicon 2 commits in 8ca261268068d80c0969260fff15199bad87b587..960d610e7f33889a2577f5f17c26f0d5c82b30df 2023-01-06 11:51:41 UTC to 2023-01-05 10:20:31 UTC - vec/raw: Simplify `RawVec::grow` (rust-lang/nomicon#392) - borrow-splitting: Use `take` instead of `replace` (rust-lang/nomicon#391) ## rust-lang/reference 4 commits in 3ae62681ff236d5528ef7c8c28ba7c6b2ecc6731..2cb0ed9ba56360949f492f9866afe8c293f9f9da 2023-01-13 03:16:35 UTC to 2023-01-07 00:08:06 UTC - Update field-expr.md (rust-lang/reference#1318) - Update documentation for arbitrary_enum_discriminant feature (rust-lang/reference#1055) - Add links to definitions of terminology ... (rust-lang/reference#1315) - Enable triagebot shortcuts (rust-lang/reference#1314) ## rust-lang/rust-by-example 2 commits in 8888f9428fe9a48f31de6bd2cef9b9bf80791edc..a9fb7d13eadfcc5f457962731f105b97f9a7474a 2023-01-14 10:25:39 UTC to 2023-01-11 18:25:42 UTC - get_or_insert example: print my_fruit as intended (rust-lang/rust-by-example#1664) - Update print.md (rust-lang/rust-by-example#1663) ## rust-lang/rustc-dev-guide 8 commits in b3e2a6e..7352353 2023-01-14 20:34:23 UTC to 2023-01-02 23:35:09 UTC - fix examples for rustc 1.68.0-nightly (935dc07 2022-12-19) (rust-lang#1556) (rust-lang/rustc-dev-guide#1557) - Update incremental-compilation-in-detail.md (rust-lang/rustc-dev-guide#1553) - Link to the youtube recording of my talk, not the summary (rust-lang/rustc-dev-guide#1554) - Change `src/test` to `tests` (rust-lang/rustc-dev-guide#1547) - add full name for ICE (rust-lang/rustc-dev-guide#1552) - Fix incorrect links (rust-lang/rustc-dev-guide#1549) - fix rebase link (rust-lang/rustc-dev-guide#1546) - Add a section for how to review code more easily (rust-lang/rustc-dev-guide#1538)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git range-diff. This section is still mostly incomplete; fixing an exact command that will work seems kinda tricky and I don't currently have time for it.