rustc: rename ty::maps to ty::query. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-i-m
suggested changes
Jun 15, 2018
src/high-level-overview.md
Outdated
| @@ -85,7 +85,7 @@ input, running the type-checker, and so forth. This on-demand model | |||
| permits us to do exciting things like only do the minimal amount of | |||
| work needed to type-check a single function. It also helps with | |||
| incremental compilation. (For details on defining queries, check out | |||
| `src/librustc/ty/maps/README.md`.) | |||
| `src/librustc/ty/query/README.md`.) | |||
There was a problem hiding this comment.
Actually could you change this to a link to the queries/incr comp chapter?
src/query.md
Outdated
| @@ -215,14 +215,14 @@ Well, defining a query takes place in two steps: | |||
|
|
|||
| To specify the query name and arguments, you simply add an entry to | |||
| the big macro invocation in | |||
| [`src/librustc/ty/maps/mod.rs`][maps-mod]. This will probably have | |||
| [`src/librustc/ty/query/mod.rs`][query-mod]. This will probably have | |||
| changed by the time you read this README, but at present it looks | |||
| something like: | |||
There was a problem hiding this comment.
Could you please remove the last sentence (even though you didn't add it)?
|
Ping @eddyb |
|
Somehow I didn't get notified on this, weird! (or I dismissed it thinking it was the rust-lang/rust PR) |
|
@mark-i-m Updated. |
|
Thanks! I will take a look tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rust-lang/rust#51550.