Update some outdated descriptions of coverage instrumentation #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not familiar with that, could you point to a relevant PR (or ping a better reviewer)? |
|
This is mainly based on my own recent work in rust-lang/rust#116046. It used to be that mappings between coverage counters and source code regions were stored directly in special coverage statements that the coverage instrumentor would inject into MIR. After that change, those mappings are now stored in a The part about injecting counters into MIR has been obsoleted by follow-up work in rust-lang/rust#116917. What used to be a fairly intricate region of code for injecting various things into MIR has been replaced by two fairly simple loops. |
|
cc @Swatinem in case you want to look over this as well. |
Zalathar
commented
Oct 30, 2023
Comment on lines
-330
to
-332
| (with no internal branching), plus a `CoverageKind` counter (to | ||
| be added, via coverage analysis), and an optional set of additional counters | ||
| to count incoming edges (if there are more than one). |
There was a problem hiding this comment.
The extra fields mentioned here were moved out into side-tables in CoverageCounters in rust-lang/rust#114354.
Zalathar
commented
Oct 30, 2023
Comment on lines
-346
to
-350
| statements. This is done by three distinct functions: | ||
| - `inject_coverage_span_counters()` | ||
| - `inject_indirect_counters()` | ||
| - `inject_intermediate_expression()`, called for each intermediate expression | ||
| returned from `make_bcb_counters()` |
There was a problem hiding this comment.
The three inject function mentioned here were removed by rust-lang/rust#116917, and replaced with a much simpler pair of loops in create_mappings_and_inject_coverage_statements.
Swatinem
approved these changes
Oct 30, 2023
davidtwco
approved these changes
Nov 4, 2023
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 7, 2023
Update books ## rust-lang/reference 4 commits in 16fd3c06d9e558dae2d52000818274ae70c9e90a..cd8193e972f61b92117095fc73b67af767b4d6bc 2023-11-04 17:19:39 UTC to 2023-10-30 16:04:52 UTC - Guarantee that raw pointer conversions preserve slice element count (rust-lang/reference#1417) - some asm block flags also mean there can be no fences (rust-lang/reference#1413) - Guarantee `char` layout (rust-lang/reference#1401) - Doc: Add the RISC-V stabilized target features (rust-lang/reference#1415) ## rust-lang/rust-by-example 3 commits in 6709beeb7d0fbc5ffc91ac4893a24434123b9bfa..311b84962016b28c75525c86e7b3f49fd9101a39 2023-10-31 18:32:09 UTC to 2023-10-31 18:30:39 UTC - Fixed explanation mistake in comment (rust-lang/rust-by-example#1761) - Fix typos (rust-lang/rust-by-example#1759) - docs(9.2): fix typo (rust-lang/rust-by-example#1754) ## rust-lang/rustc-dev-guide 6 commits in b0ee9ec8fa59a6c7620165e061f4747202377a62..77dbe5782b2488af3bb489ad702eaff438f465bf 2023-11-06 16:14:34 UTC to 2023-10-29 17:16:02 UTC - add a new type system invariant (rust-lang/rustc-dev-guide#1822) - Update some outdated descriptions of coverage instrumentation (rust-lang/rustc-dev-guide#1809) - Add some documentation for unsizing (rust-lang/rustc-dev-guide#1817) - Bibliography: fixing author of "You Can't Spell Trust Without Rust" (rust-lang/rustc-dev-guide#1815) - remove change-id from sample build configuration (rust-lang/rustc-dev-guide#1813) - Update name of "active" features to "unstable" (rust-lang/rustc-dev-guide#1814)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2023
Rollup merge of rust-lang#117639 - rustbot:docs-update, r=ehuss Update books ## rust-lang/reference 4 commits in 16fd3c06d9e558dae2d52000818274ae70c9e90a..cd8193e972f61b92117095fc73b67af767b4d6bc 2023-11-04 17:19:39 UTC to 2023-10-30 16:04:52 UTC - Guarantee that raw pointer conversions preserve slice element count (rust-lang/reference#1417) - some asm block flags also mean there can be no fences (rust-lang/reference#1413) - Guarantee `char` layout (rust-lang/reference#1401) - Doc: Add the RISC-V stabilized target features (rust-lang/reference#1415) ## rust-lang/rust-by-example 3 commits in 6709beeb7d0fbc5ffc91ac4893a24434123b9bfa..311b84962016b28c75525c86e7b3f49fd9101a39 2023-10-31 18:32:09 UTC to 2023-10-31 18:30:39 UTC - Fixed explanation mistake in comment (rust-lang/rust-by-example#1761) - Fix typos (rust-lang/rust-by-example#1759) - docs(9.2): fix typo (rust-lang/rust-by-example#1754) ## rust-lang/rustc-dev-guide 6 commits in b0ee9ec8fa59a6c7620165e061f4747202377a62..77dbe5782b2488af3bb489ad702eaff438f465bf 2023-11-06 16:14:34 UTC to 2023-10-29 17:16:02 UTC - add a new type system invariant (rust-lang/rustc-dev-guide#1822) - Update some outdated descriptions of coverage instrumentation (rust-lang/rustc-dev-guide#1809) - Add some documentation for unsizing (rust-lang/rustc-dev-guide#1817) - Bibliography: fixing author of "You Can't Spell Trust Without Rust" (rust-lang/rustc-dev-guide#1815) - remove change-id from sample build configuration (rust-lang/rustc-dev-guide#1813) - Update name of "active" features to "unstable" (rust-lang/rustc-dev-guide#1814)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage internals have changed quite a bit over recent months/weeks, so I decided to at least make a pass over the existing docs and update anything that is clearly outdated.